Home Original page

test: fix defect path traversal tests by tniessen · Pull Request #50124 · nodejs/node

@tniessen added permission

Issues and PRs related to the Permission Model

test

Issues and PRs related to the tests.

security

Issues and PRs related to security.

labels

Oct 10, 2023

@tniessen tniessen added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Oct 11, 2023

Trott

Trott previously approved these changes Oct 11, 2023

@tniessen 

The test never actually tested what it claims to test because it did not
properly insert separators before `..`.

RafaelGSS

kumarrishav pushed a commit to kumarrishav/node that referenced this pull request

Oct 16, 2023 
The test never actually tested what it claims to test because it did not
properly insert separators before `..`.

PR-URL: nodejs#50124
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

targos pushed a commit that referenced this pull request

Oct 23, 2023 
The test never actually tested what it claims to test because it did not
properly insert separators before `..`.

PR-URL: #50124
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

alexfernandez pushed a commit to alexfernandez/node that referenced this pull request

Nov 1, 2023 
The test never actually tested what it claims to test because it did not
properly insert separators before `..`.

PR-URL: nodejs#50124
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

targos pushed a commit that referenced this pull request

Nov 11, 2023 
The test never actually tested what it claims to test because it did not
properly insert separators before `..`.

PR-URL: #50124
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>