Home Original page

benchmark: skip test-benchmark-os on IBMi by mhdawson · Pull Request #50286 · nodejs/node

@mhdawson 

- IBMi does not have the os.uptime implemented so skip
  otherwise CI tests fail.

Signed-off-by: Michael Dawson <midawson@redhat.com>

@nodejs-github-bot added benchmark

Issues and PRs related to the benchmark subsystem.

needs-ci

PRs that need a full CI run.

performance

Issues and PRs related to the performance of Node.js.

test

Issues and PRs related to the tests.

labels

Oct 19, 2023

@mhdawson 

Signed-off-by: Michael Dawson <midawson@redhat.com>

H4ad

@mhdawson 

Signed-off-by: Michael Dawson <midawson@redhat.com>

H4ad

H4ad

H4ad approved these changes Oct 19, 2023

@H4ad H4ad added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Oct 19, 2023

richardlau

This was referenced

Oct 21, 2023

mhdawson added a commit that referenced this pull request

Oct 24, 2023 
- IBMi does not have the os.uptime implemented so skip
  otherwise CI tests fail.

Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: #50286
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

alexfernandez pushed a commit to alexfernandez/node that referenced this pull request

Nov 1, 2023 
- IBMi does not have the os.uptime implemented so skip
  otherwise CI tests fail.

Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: nodejs#50286
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

targos pushed a commit that referenced this pull request

Nov 11, 2023 
- IBMi does not have the os.uptime implemented so skip
  otherwise CI tests fail.

Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: #50286
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

UlisesGascon pushed a commit that referenced this pull request

Dec 11, 2023 
- IBMi does not have the os.uptime implemented so skip
  otherwise CI tests fail.

Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: #50286
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>