Home Original page

test_runner: Fix mock timer promisified setInterval return value by mika-fischer · Pull Request #50331 · nodejs/node

@nodejs-github-bot added needs-ci

PRs that need a full CI run.

test_runner

Issues and PRs related to the test runner subsystem.

labels

Oct 22, 2023

atlowChemi

@atlowChemi atlowChemi added request-ci

Add this label to start a Jenkins CI on a PR.

commit-queue-squash

Add this label to instruct the Commit Queue to squash all the PR commits into the first one.

author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

labels

Oct 23, 2023

ErickWendel

@mika-fischer 

promisified setInterval can be passed a value that is returned by the
async iterable. The mocked promisified setInterval used this value for
its own purposes. This brings the mocked version in line with the
original.

Fixes: nodejs#50307
Some tests relied on the custom return value and were broken by the
change to always return the value provided by the caller.

@MoLow MoLow added the commit-queue

Add this label to land a pull request using GitHub Actions.

label

Oct 23, 2023

benjamingr

@MoLow MoLow added commit-queue

Add this label to land a pull request using GitHub Actions.

and removed commit-queue-failed

An error occurred while landing this pull request using GitHub Actions.

labels

Oct 25, 2023

@MoLow MoLow linked an issue

Oct 25, 2023

that may be closed by this pull request

alexfernandez pushed a commit to alexfernandez/node that referenced this pull request

Nov 1, 2023 
PR-URL: nodejs#50331
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

targos pushed a commit that referenced this pull request

Nov 11, 2023 
PR-URL: #50331
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

UlisesGascon pushed a commit that referenced this pull request

Dec 11, 2023 
PR-URL: #50331
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>