lib: revokeObjectURL throws error on empty args by DylanTet · Pull Request #50433

lib: revokeObjectURL throws error on empty args by DylanTet · Pull Request #50433 · nodejs/node

PRs that need a full CI run.

Issues and PRs related to the WHATWG URL implementation.

labels

Oct 27, 2023

DylanTet changed the title ~~lib: revokeObjectURL throws error if arg length is 0 in url.js~~ url: check argument length of revokeObjectURL

Oct 29, 2023

H4ad approved these changes Oct 29, 2023

H4ad added author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

request-ci

Add this label to start a Jenkins CI on a PR.

and removed request-ci

Add this label to start a Jenkins CI on a PR.

labels

Oct 29, 2023

DylanTet changed the title ~~url: check argument length of revokeObjectURL~~ lib: revokeObjectURL throws error on empty args

Oct 30, 2023

Added a check to see if url wasn't included as an argument
which will then throw an error.

Fixes: nodejs#50432

H4ad approved these changes Nov 30, 2023

H4ad added the commit-queue

Add this label to land a pull request using GitHub Actions.

label

Nov 30, 2023

targos pushed a commit that referenced this pull request

Dec 4, 2023

Added a check to see if url wasn't included as an argument
which will then throw an error.

Fixes: #50432
PR-URL: #50433
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>

richardlau pushed a commit that referenced this pull request

Mar 25, 2024

Added a check to see if url wasn't included as an argument
which will then throw an error.

Fixes: #50432
PR-URL: #50433
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>