Home Original page

test: remove unused file by jsumners · Pull Request #50528 · nodejs/node

@nodejs-github-bot added needs-ci

PRs that need a full CI run.

node-api

Issues and PRs related to the Node-API.

test

Issues and PRs related to the tests.

labels

Nov 2, 2023

@jsumners jsumners changed the title chore: remove unused file src: remove unused file

Nov 2, 2023

legendecas

tniessen

@jsumners jsumners changed the title src: remove unused file test: remove unused file

Nov 3, 2023

@jsumners 

This removes a source file that got re-added via a rebase.
It seems somewhere around change set
nodejs@178dff2
`entry_point.c` was removed, and rebase
nodejs@0b6e16f
added it back. The review of nodejs#48740
overlooked this and the file got re-committed.

@legendecas legendecas added author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

commit-queue

Add this label to land a pull request using GitHub Actions.

labels

Nov 10, 2023

legendecas

targos pushed a commit that referenced this pull request

Nov 11, 2023 
This removes a source file that got re-added via a rebase.
It seems somewhere around change set
178dff2
`entry_point.c` was removed, and rebase
0b6e16f
added it back. The review of #48740
overlooked this and the file got re-committed.

PR-URL: #50528
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Vladimir Morozov <vmorozov@microsoft.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

targos pushed a commit that referenced this pull request

Nov 14, 2023 
This removes a source file that got re-added via a rebase.
It seems somewhere around change set
178dff2
`entry_point.c` was removed, and rebase
0b6e16f
added it back. The review of #48740
overlooked this and the file got re-committed.

PR-URL: #50528
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Vladimir Morozov <vmorozov@microsoft.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

UlisesGascon pushed a commit that referenced this pull request

Dec 11, 2023 
This removes a source file that got re-added via a rebase.
It seems somewhere around change set
178dff2
`entry_point.c` was removed, and rebase
0b6e16f
added it back. The review of #48740
overlooked this and the file got re-committed.

PR-URL: #50528
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Vladimir Morozov <vmorozov@microsoft.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>