Home Original page

test: log more information in SEA tests by joyeecheung · Pull Request #50759 · nodejs/node

@nodejs-github-bot added needs-ci

PRs that need a full CI run.

test

Issues and PRs related to the tests.

labels

Nov 16, 2023

@joyeecheung joyeecheung changed the title test: improve SEA tests test: log more information in SEA tests

Nov 16, 2023

@anonrig anonrig added fast-track

PRs that do not need to wait for 72 hours to land.

author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

labels

Nov 17, 2023

RaisinTen

@joyeecheung 

- Use spawnSyncAndExitWithoutError to log more information on error.
- Use NODE_DEBUG_NATIVE to log internals
- Skip the test when available disk space < 120MB

RaisinTen

nodejs-github-bot pushed a commit that referenced this pull request

Nov 28, 2023 
PR-URL: #50759
Refs: #50740
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>

nodejs-github-bot pushed a commit that referenced this pull request

Nov 28, 2023 
- Use spawnSyncAndExitWithoutError to log more information on error.
- Use NODE_DEBUG_NATIVE to log internals
- Skip the test when available disk space < 120MB

PR-URL: #50759
Refs: #50740
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>

targos pushed a commit that referenced this pull request

Dec 4, 2023 
PR-URL: #50759
Refs: #50740
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>

targos pushed a commit that referenced this pull request

Dec 4, 2023 
- Use spawnSyncAndExitWithoutError to log more information on error.
- Use NODE_DEBUG_NATIVE to log internals
- Skip the test when available disk space < 120MB

PR-URL: #50759
Refs: #50740
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>

richardlau pushed a commit that referenced this pull request

Mar 25, 2024 
PR-URL: #50759
Refs: #50740
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>

richardlau pushed a commit that referenced this pull request

Mar 25, 2024 
- Use spawnSyncAndExitWithoutError to log more information on error.
- Use NODE_DEBUG_NATIVE to log internals
- Skip the test when available disk space < 120MB

PR-URL: #50759
Refs: #50740
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>