Home Original page

fs: use w flag for writeFileSync with utf8 encoding when flag not specified by MuriloKakazu · Pull Request #50990 · nodejs/node

@nodejs-github-bot added fs

Issues and PRs related to the fs subsystem / file system.

needs-ci

PRs that need a full CI run.

labels

Dec 1, 2023

@MuriloKakazu MuriloKakazu changed the title fix: defaults to write flag when not specified for writeFileSync fs: use w flag for writeFileSync with utf8 encoding when flag not specified

Dec 1, 2023

This was referenced

Dec 1, 2023

@MuriloKakazu

@MuriloKakazu

chenrui333

@anonrig anonrig added author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

commit-queue

Add this label to land a pull request using GitHub Actions.

labels

Dec 2, 2023

@anonrig anonrig added commit-queue

Add this label to land a pull request using GitHub Actions.

commit-queue-squash

Add this label to instruct the Commit Queue to squash all the PR commits into the first one.

and removed commit-queue-failed

An error occurred while landing this pull request using GitHub Actions.

labels

Dec 3, 2023

targos pushed a commit that referenced this pull request

Dec 4, 2023 
PR-URL: #50990
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>

targos added a commit that referenced this pull request

Dec 4, 2023 
Notable changes:

fs:
  * (SEMVER-MINOR) introduce `dirent.parentPath` (Antoine du Hamel) #50976
  * use default w flag for writeFileSync with utf8 encoding (Murilo Kakazu) #50990

PR-URL: #51043

ljharb added a commit to import-js/eslint-plugin-import that referenced this pull request

Dec 4, 2023

targos added a commit to targos/node that referenced this pull request

Dec 5, 2023 
Notable changes:

fs:
  * (SEMVER-MINOR) introduce `dirent.parentPath` (Antoine du Hamel) nodejs#50976
  * use default w flag for writeFileSync with utf8 encoding (Murilo Kakazu) nodejs#50990

PR-URL: nodejs#51043

targos added a commit that referenced this pull request

Dec 5, 2023 
Notable changes:

fs:
  * (SEMVER-MINOR) introduce `dirent.parentPath` (Antoine du Hamel) #50976
  * use default w flag for writeFileSync with utf8 encoding (Murilo Kakazu) #50990

PR-URL: #51043

UlisesGascon pushed a commit that referenced this pull request

Jan 3, 2024 
PR-URL: #50990
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>

UlisesGascon pushed a commit that referenced this pull request

Jan 9, 2024 
PR-URL: #50990
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>