win: build fixes by piscisaureus · Pull Request #512 · nodejs/node

@piscisaureus mentioned this pull request

Jan 19, 2015
Chrome still runs on Windows XP, so there is no reason that iojs
couldn't.

PR: nodejs#512
Reviewed-by: Ben Noordhuis <info@bnoordhuis.nl>
The duplicate warning was fixed by e1fe270, but returned as of 9f45799.
Hopefully this will fix the issue for good.

PR: nodejs#512
Reviewed-by: Ben Noordhuis <info@bnoordhuis.nl>

@rvagg rvagg mentioned this pull request

Mar 9, 2015

piscisaureus added a commit to nodejs/node-v0.x-archive that referenced this pull request

May 22, 2015
Issue: #25348
The gyp/project files don't explicitly specify a subsystem version,
which results in the default being used. The default changed from
VS 2010 to VS 2012 and later.

Backport e8d0850 from io.js.
Original commit message follows:

Chrome still runs on Windows XP, so there is no reason that iojs
couldn't.

PR: nodejs/node#512
(cherry picked from commit e8d0850)

Reviewed-By: Julien Gilli <julien.gilli@joyent.com>
PR-URL: #25367

misterdjules pushed a commit to misterdjules/node that referenced this pull request

Jun 19, 2015
Issue: nodejs#25348
The gyp/project files don't explicitly specify a subsystem version,
which results in the default being used. The default changed from
VS 2010 to VS 2012 and later.

Backport 3122052, which itself
backports e8d0850 from io.js.
Original commit message follows:

Chrome still runs on Windows XP, so there is no reason that iojs
couldn't.

PR: nodejs/node#512
(cherry picked from commit e8d0850)

Reviewed-By: Julien Gilli <julien.gilli@joyent.com>
PR-URL: nodejs#25367

Conflicts:
	node.gyp

misterdjules pushed a commit to misterdjules/node that referenced this pull request

Jun 24, 2015
Issue: nodejs#25348
The gyp/project files don't explicitly specify a subsystem version,
which results in the default being used. The default changed from
VS 2010 to VS 2012 and later.

Backport 3122052, which itself
backports e8d0850 from io.js.
Original commit message follows:

Chrome still runs on Windows XP, so there is no reason that iojs
couldn't.

PR: nodejs/node#512
(cherry picked from commit e8d0850)

Reviewed-By: Julien Gilli <julien.gilli@joyent.com>
PR-URL: nodejs#25367

Conflicts:
	node.gyp

misterdjules pushed a commit to misterdjules/node that referenced this pull request

Jun 24, 2015
Issue: nodejs#25348
The gyp/project files don't explicitly specify a subsystem version,
which results in the default being used. The default changed from
VS 2010 to VS 2012 and later.

Backport 3122052, which itself
backports e8d0850 from io.js.
Original commit message follows:

  Chrome still runs on Windows XP, so there is no reason that iojs
  couldn't.

  PR: nodejs/node#512
  (cherry picked from commit e8d0850)

  Reviewed-By: Julien Gilli <julien.gilli@joyent.com>
  PR-URL: nodejs#25367

Conflicts:
	node.gyp

misterdjules pushed a commit to misterdjules/node that referenced this pull request

Jul 21, 2015
Issue: nodejs#25348
The gyp/project files don't explicitly specify a subsystem version,
which results in the default being used. The default changed from
VS 2010 to VS 2012 and later.

Backport 3122052, which itself
backports e8d0850 from io.js.
Original commit message follows:

  Chrome still runs on Windows XP, so there is no reason that iojs
  couldn't.

  PR: nodejs/node#512
  (cherry picked from commit e8d0850)

  Reviewed-By: Julien Gilli <julien.gilli@joyent.com>
  PR-URL: nodejs#25367

Conflicts:
	node.gyp

misterdjules pushed a commit to misterdjules/node that referenced this pull request

Jul 23, 2015
Issue: nodejs#25348
The gyp/project files don't explicitly specify a subsystem version,
which results in the default being used. The default changed from
VS 2010 to VS 2012 and later.

Backport 3122052, which itself
backports e8d0850 from io.js.
Original commit message follows:

  Chrome still runs on Windows XP, so there is no reason that iojs
  couldn't.

  PR: nodejs/node#512
  (cherry picked from commit e8d0850)

  Reviewed-By: Julien Gilli <julien.gilli@joyent.com>
  PR-URL: nodejs#25367

Conflicts:
	node.gyp

misterdjules pushed a commit to nodejs/node-v0.x-archive that referenced this pull request

Jul 23, 2015
Issue: #25348
The gyp/project files don't explicitly specify a subsystem version,
which results in the default being used. The default changed from
VS 2010 to VS 2012 and later.

Backport 3122052, which itself
backports e8d0850 from io.js.
Original commit message follows:

  Chrome still runs on Windows XP, so there is no reason that iojs
  couldn't.

  PR: nodejs/node#512
  (cherry picked from commit e8d0850)

  Reviewed-By: Julien Gilli <julien.gilli@joyent.com>
  PR-URL: #25367

Conflicts:
	node.gyp

Reviewed-By: João Reis <reis@janeasystems.com>
PR-URL: #25569