Home Original page

tools: fix version parsing in brotli update script by richardlau · Pull Request #51373 · nodejs/node

@richardlau 

Update `tools/dep_updaters/update-brotli.sh` to parse the current
version of brotli from the newer macros `BROTLI_VERSION_MAJOR`,
`BROTLI_VERSION_MINOR` and `BROTLI_VERSION_PATCH`.

@nodejs-github-bot added the tools

Issues and PRs related to the tools directory.

label

Jan 4, 2024

marco-ippolito

@richardlau richardlau added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Jan 4, 2024

marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request

Jan 12, 2024 
Update `tools/dep_updaters/update-brotli.sh` to parse the current
version of brotli from the newer macros `BROTLI_VERSION_MAJOR`,
`BROTLI_VERSION_MINOR` and `BROTLI_VERSION_PATCH`.

PR-URL: nodejs#51373
Refs: nodejs#50804
Refs: nodejs/security-wg#1181
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

Medhansh404 pushed a commit to Medhansh404/node that referenced this pull request

Jan 19, 2024 
Update `tools/dep_updaters/update-brotli.sh` to parse the current
version of brotli from the newer macros `BROTLI_VERSION_MAJOR`,
`BROTLI_VERSION_MINOR` and `BROTLI_VERSION_PATCH`.

PR-URL: nodejs#51373
Refs: nodejs#50804
Refs: nodejs/security-wg#1181
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

targos pushed a commit that referenced this pull request

Feb 15, 2024 
Update `tools/dep_updaters/update-brotli.sh` to parse the current
version of brotli from the newer macros `BROTLI_VERSION_MAJOR`,
`BROTLI_VERSION_MINOR` and `BROTLI_VERSION_PATCH`.

PR-URL: #51373
Refs: #50804
Refs: nodejs/security-wg#1181
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

richardlau added a commit that referenced this pull request

Mar 25, 2024 
Update `tools/dep_updaters/update-brotli.sh` to parse the current
version of brotli from the newer macros `BROTLI_VERSION_MAJOR`,
`BROTLI_VERSION_MINOR` and `BROTLI_VERSION_PATCH`.

PR-URL: #51373
Refs: #50804
Refs: nodejs/security-wg#1181
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

richardlau added a commit that referenced this pull request

Mar 25, 2024 
Update `tools/dep_updaters/update-brotli.sh` to parse the current
version of brotli from the newer macros `BROTLI_VERSION_MAJOR`,
`BROTLI_VERSION_MINOR` and `BROTLI_VERSION_PATCH`.

PR-URL: #51373
Refs: #50804
Refs: nodejs/security-wg#1181
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>