Home Original page

test_runner: do not invoke after hook when test is empty by marco-ippolito · Pull Request #51389 · nodejs/node

@marco-ippolito

@nodejs-github-bot added needs-ci

PRs that need a full CI run.

test_runner

Issues and PRs related to the test runner subsystem.

labels

Jan 5, 2024

atlowChemi

marco-ippolito added a commit to marco-ippolito/node that referenced this pull request

Jan 12, 2024 
PR-URL: nodejs#51389
Fixes: nodejs#51371
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>

Medhansh404 pushed a commit to Medhansh404/node that referenced this pull request

Jan 19, 2024 
PR-URL: nodejs#51389
Fixes: nodejs#51371
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>

targos pushed a commit that referenced this pull request

Feb 15, 2024 
PR-URL: #51389
Fixes: #51371
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>

targos added a commit that referenced this pull request

Mar 7, 2024 
Notable changes:

This release reverts #51389,
which landed in Node.js 21.7.0. It is a documented feature that
`t.after()` hooks are run even if a test has no subtests. The hook can
be used to clean up the test itself.

PR-URL: #52002

@MoLow MoLow mentioned this pull request

Mar 7, 2024

targos added a commit that referenced this pull request

Mar 8, 2024 
Notable changes:

This release reverts #51389,
which landed in Node.js 21.7.0. It is a documented feature that
`t.after()` hooks are run even if a test has no subtests. The hook can
be used to clean up the test itself.

PR-URL: #52002

targos added a commit that referenced this pull request

Mar 8, 2024 
Notable changes:

This release reverts #51389,
which landed in Node.js 21.7.0. It is a documented feature that
`t.after()` hooks are run even if a test has no subtests. The hook can
be used to clean up the test itself.

PR-URL: #52002

targos added a commit that referenced this pull request

Mar 8, 2024 
Notable changes:

This release reverts #51389,
which landed in Node.js 21.7.0. It is a documented feature that
`t.after()` hooks are run even if a test has no subtests. The hook can
be used to clean up the test itself.

PR-URL: #52002

rdw-msft pushed a commit to rdw-msft/node that referenced this pull request

Mar 26, 2024 
Notable changes:

This release reverts nodejs#51389,
which landed in Node.js 21.7.0. It is a documented feature that
`t.after()` hooks are run even if a test has no subtests. The hook can
be used to clean up the test itself.

PR-URL: nodejs#52002

jcbhmr pushed a commit to jcbhmr/node that referenced this pull request

May 15, 2024 
Notable changes:

This release reverts nodejs#51389,
which landed in Node.js 21.7.0. It is a documented feature that
`t.after()` hooks are run even if a test has no subtests. The hook can
be used to clean up the test itself.

PR-URL: nodejs#52002