Home Original page

build: fix building js2c with GN by zcbenz · Pull Request #51818 · nodejs/node

@zcbenz added fast-track

PRs that do not need to wait for 72 hours to land.

request-ci

Add this label to start a Jenkins CI on a PR.

labels

Feb 21, 2024

joyeecheung

@zcbenz

@zcbenz zcbenz added commit-queue-squash

Add this label to instruct the Commit Queue to squash all the PR commits into the first one.

commit-queue

Add this label to land a pull request using GitHub Actions.

labels

Feb 23, 2024

zcbenz added a commit that referenced this pull request

Feb 23, 2024 
This is a follow-up to #51605.

PR-URL: #51818
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

marco-ippolito pushed a commit that referenced this pull request

Feb 26, 2024 
This is a follow-up to #51605.

PR-URL: #51818
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

marco-ippolito pushed a commit that referenced this pull request

Feb 26, 2024 
This is a follow-up to #51605.

PR-URL: #51818
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

marco-ippolito pushed a commit that referenced this pull request

Feb 27, 2024 
This is a follow-up to #51605.

PR-URL: #51818
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

richardlau pushed a commit that referenced this pull request

Mar 25, 2024 
This is a follow-up to #51605.

PR-URL: #51818
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

richardlau pushed a commit that referenced this pull request

Mar 25, 2024 
This is a follow-up to #51605.

PR-URL: #51818
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

rdw-msft pushed a commit to rdw-msft/node that referenced this pull request

Mar 26, 2024 
This is a follow-up to nodejs#51605.

PR-URL: nodejs#51818
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>