diagnostics_channel: early-exit tracing channel trace methods by Qard · Pull Request #51915 · nodejs/node

diagnostics_channel: early-exit tracing channel trace methods by Qard · Pull Request #51915 · nodejs/node

added doc

Issues and PRs related to the documentations.

Issues and PRs related to the tests.

Issues and PRs to discuss during the meetings of the diagnostics working group.

diagnostics_channel

Issues and PRs related to diagnostics channel

labels

Qard added the commit-queue

Add this label to land a pull request using GitHub Actions.

label

Qard deleted the tracing-channel-early-return branch

March 7, 2024 17:50

rdw-msft pushed a commit to rdw-msft/node that referenced this pull request

PR-URL: nodejs#51915
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

marco-ippolito pushed a commit that referenced this pull request

PR-URL: #51915
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

This was referenced

May 8, 2024

tlhunter added a commit to tlhunter/node that referenced this pull request

tlhunter added a commit to tlhunter/node that referenced this pull request

tlhunter added a commit to tlhunter/node that referenced this pull request

tlhunter added a commit to tlhunter/node that referenced this pull request

tlhunter added a commit to tlhunter/node that referenced this pull request

tlhunter added a commit to DataDog/dc-polyfill that referenced this pull request

- some `diagnostics_channel` changes landed in Node.js in nodejs/node#51915
  - this PR adds the `TracingChannel#hasSubscribers` helper method available in Node.js v22 and v20.13
  - this PR _does not_ add the early exit functionality from that same commit
- since this PR only implements half of the functionality in that commit we aren't fully v22 and v20.13 compatible
  - for that reason I haven't updated the README to state that we track said versions
  - I did add a note to the README about this partial jump in functionality
- this PR also adds CI tests against Node.js v22.x
- partially obsoletes #10 which is a WIP that attempted to implement both

tlhunter added a commit to tlhunter/node that referenced this pull request

tlhunter added a commit to tlhunter/node that referenced this pull request

tlhunter added a commit to tlhunter/node that referenced this pull request

jcbhmr pushed a commit to jcbhmr/node that referenced this pull request

PR-URL: nodejs#51915
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

nodejs-github-bot pushed a commit that referenced this pull request

follow up work for #51915

PR-URL: #52908
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

targos pushed a commit that referenced this pull request

follow up work for #51915

PR-URL: #52908
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

RafaelGSS pushed a commit that referenced this pull request

follow up work for #51915

PR-URL: #52908
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

marco-ippolito pushed a commit that referenced this pull request

follow up work for #51915

PR-URL: #52908
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

marco-ippolito pushed a commit that referenced this pull request

follow up work for #51915

PR-URL: #52908
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

marco-ippolito pushed a commit that referenced this pull request

follow up work for #51915

PR-URL: #52908
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: James M Snell <jasnell@gmail.com>