Home Original page

doc: document that `const c2 = vm.createContext(c1); c1 === c2` is true by DanKaplanSES · Pull Request #51960 · nodejs/node

@DanKaplanSES 

- As far as I can tell, the documentation didn't say this, so I was left
  wondering if there is a difference between `c1` and `c2` in `const c2
= vm.createContext(c1);` According to my own tests, they are equivalent.
I thought it was worth documenting as it would've saved me a bit of time
if this information were written down.

@nodejs-github-bot added doc

Issues and PRs related to the documentations.

vm

Issues and PRs related to the vm subsystem.

labels

Mar 4, 2024

@DanKaplanSES

@lpinca lpinca added the commit-queue-squash

Add this label to instruct the Commit Queue to squash all the PR commits into the first one.

label

Mar 5, 2024

legendecas

@lpinca lpinca added the commit-queue

Add this label to land a pull request using GitHub Actions.

label

Mar 9, 2024

rdw-msft pushed a commit to rdw-msft/node that referenced this pull request

Mar 26, 2024 
- As far as I can tell, the documentation didn't say this, so I was left
  wondering if there is a difference between `c1` and `c2` in `const c2
= vm.createContext(c1);` According to my own tests, they are equivalent.
I thought it was worth documenting as it would've saved me a bit of time
if this information were written down.

PR-URL: nodejs#51960
Refs: nodejs#51946
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

marco-ippolito pushed a commit that referenced this pull request

May 2, 2024 
- As far as I can tell, the documentation didn't say this, so I was left
  wondering if there is a difference between `c1` and `c2` in `const c2
= vm.createContext(c1);` According to my own tests, they are equivalent.
I thought it was worth documenting as it would've saved me a bit of time
if this information were written down.

PR-URL: #51960
Refs: #51946
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

jcbhmr pushed a commit to jcbhmr/node that referenced this pull request

May 15, 2024 
- As far as I can tell, the documentation didn't say this, so I was left
  wondering if there is a difference between `c1` and `c2` in `const c2
= vm.createContext(c1);` According to my own tests, they are equivalent.
I thought it was worth documenting as it would've saved me a bit of time
if this information were written down.

PR-URL: nodejs#51960
Refs: nodejs#51946
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>