Home Original page

test: un-set test-emit-after-on-destroyed as flaky by abmusse · Pull Request #51995 · nodejs/node

@abmusse 

I tested running the test case 100k times on the AIX ci machine
and was unable to re-produce the error. Also it has not showed up
recently as flaky on the ci. I suggest we mark this
as un-flaky.

ref: #50245 (comment)

@nodejs-github-bot added async_hooks

Issues and PRs related to the async hooks subsystem.

needs-ci

PRs that need a full CI run.

test

Issues and PRs related to the tests.

labels

Mar 6, 2024

richardlau

@richardlau richardlau linked an issue

Mar 7, 2024

that may be closed by this pull request

mhdawson

@abmusse abmusse deleted the unmark-flaky-test-emit-after-on-destroyed branch

March 10, 2024 07:13

rdw-msft pushed a commit to rdw-msft/node that referenced this pull request

Mar 26, 2024 
I tested running the test case 100k times on the AIX ci machine
and was unable to re-produce the error. Also it has not showed up
recently as flaky on the ci. I suggest we mark this
as un-flaky.

ref: nodejs#50245 (comment)
PR-URL: nodejs#51995
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

marco-ippolito pushed a commit that referenced this pull request

May 2, 2024 
I tested running the test case 100k times on the AIX ci machine
and was unable to re-produce the error. Also it has not showed up
recently as flaky on the ci. I suggest we mark this
as un-flaky.

ref: #50245 (comment)
PR-URL: #51995
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

jcbhmr pushed a commit to jcbhmr/node that referenced this pull request

May 15, 2024 
I tested running the test case 100k times on the AIX ci machine
and was unable to re-produce the error. Also it has not showed up
recently as flaky on the ci. I suggest we mark this
as un-flaky.

ref: nodejs#50245 (comment)
PR-URL: nodejs#51995
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

@sxa sxa mentioned this pull request

Jan 14, 2026