Home Original page

misc cleanup by mscdex · Pull Request #5233 · nodejs/node

added 3 commits

February 15, 2016 04:45
The value's type is unsigned so it will always be >= 0.
The value passed to `process.nextTick()` which is passed to the
callback is already a valid object, so the conditional will always
evaluate to true.
The comment refers to a property (called `_pendings`) that no longer
exists.

@mscdex mscdex added http

Issues or PRs related to the http subsystem.

lib / src

Issues and PRs related to general changes in the lib or src directory.

labels

Feb 15, 2016

jasnell pushed a commit that referenced this pull request

Feb 15, 2016 
The value's type is unsigned so it will always be >= 0.

PR-URL: #5233
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>

jasnell pushed a commit that referenced this pull request

Feb 15, 2016 
The value passed to `process.nextTick()` which is passed to the
callback is already a valid object, so the conditional will always
evaluate to true.

PR-URL: #5233
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>

jasnell pushed a commit that referenced this pull request

Feb 15, 2016 
The comment refers to a property (called `_pendings`) that no longer
exists.

PR-URL: #5233
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>

rvagg pushed a commit that referenced this pull request

Feb 15, 2016 
The value's type is unsigned so it will always be >= 0.

PR-URL: #5233
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>

rvagg pushed a commit that referenced this pull request

Feb 15, 2016 
The value passed to `process.nextTick()` which is passed to the
callback is already a valid object, so the conditional will always
evaluate to true.

PR-URL: #5233
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>

rvagg pushed a commit that referenced this pull request

Feb 15, 2016 
The comment refers to a property (called `_pendings`) that no longer
exists.

PR-URL: #5233
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>

stefanmb pushed a commit to stefanmb/node that referenced this pull request

Feb 23, 2016 
The value's type is unsigned so it will always be >= 0.

PR-URL: nodejs#5233
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>

stefanmb pushed a commit to stefanmb/node that referenced this pull request

Feb 23, 2016 
The value passed to `process.nextTick()` which is passed to the
callback is already a valid object, so the conditional will always
evaluate to true.

PR-URL: nodejs#5233
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>

stefanmb pushed a commit to stefanmb/node that referenced this pull request

Feb 23, 2016 
The comment refers to a property (called `_pendings`) that no longer
exists.

PR-URL: nodejs#5233
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Mar 17, 2016 
The value passed to `process.nextTick()` which is passed to the
callback is already a valid object, so the conditional will always
evaluate to true.

PR-URL: #5233
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Mar 17, 2016 
The comment refers to a property (called `_pendings`) that no longer
exists.

PR-URL: #5233
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Mar 21, 2016 
The value passed to `process.nextTick()` which is passed to the
callback is already a valid object, so the conditional will always
evaluate to true.

PR-URL: #5233
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Mar 21, 2016 
The comment refers to a property (called `_pendings`) that no longer
exists.

PR-URL: #5233
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Jun 7, 2016 
The value's type is unsigned so it will always be >= 0.

Ref: #7048
PR-URL: #5233
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Jun 24, 2016 
The value's type is unsigned so it will always be >= 0.

Ref: #7048
PR-URL: #5233
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Jun 28, 2016 
The value's type is unsigned so it will always be >= 0.

Ref: #7048
PR-URL: #5233
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Jul 12, 2016 
The value's type is unsigned so it will always be >= 0.

Ref: #7048
PR-URL: #5233
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>