Home Original page

[v18.x] http: remove closeIdleConnections function while calling server close. by kumarrishav · Pull Request #52336 · nodejs/node

@nodejs-github-bot added http

Issues or PRs related to the http subsystem.

needs-ci

PRs that need a full CI run.

v18.x

Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch.

labels

Apr 2, 2024

@kumarrishav kumarrishav changed the title http: remove closeIdleConnections function while calling server close. [v18.x] http: remove closeIdleConnections function while calling server close.

Apr 2, 2024

@kumarrishav 

Correcting the nodejs#50194 backporting mistake.
closeIdleConnections shouldnot be called while server.close in node v18.
This behavior is for node v19 and above.

fixes: nodejs#52330, nodejs#51677

@kumarrishav

Linkgoron

richardlau pushed a commit that referenced this pull request

Apr 17, 2024 
Correcting the #50194 backporting mistake.
closeIdleConnections shouldnot be called while server.close in node v18.
This behavior is for node v19 and above.

Fixes: #52330
Fixes: #51677
PR-URL: #52336
Refs: #50194
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>