test_runner: better error handing for test hook by himself65 · Pull Request #52401 · nodejs/node

@nodejs-github-bot added needs-ci

PRs that need a full CI run.

test_runner

Issues and PRs related to the test runner subsystem.

labels

Apr 7, 2024

@himself65 himself65 marked this pull request as ready for review

April 7, 2024 09:18

atlowChemi

MoLow

atlowChemi

cjihrig

cjihrig

@himself65 himself65 changed the title test_runner: better warning inside test hook test_runner: better error handing for test hook

Apr 9, 2024

atlowChemi

benjamingr

@himself65 @cjihrig

Co-authored-by: Colin Ihrig <cjihrig@gmail.com>

@MoLow MoLow added the commit-queue

Add this label to land a pull request using GitHub Actions.

label

Apr 15, 2024

@MoLow MoLow added commit-queue

Add this label to land a pull request using GitHub Actions.

and removed commit-queue-failed

An error occurred while landing this pull request using GitHub Actions.

labels

Apr 15, 2024

@himself65 himself65 deleted the himself65/20240407/better-error-handler branch

April 22, 2024 16:33

aduh95 pushed a commit that referenced this pull request

Apr 29, 2024
Co-authored-by: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #52401
Fixes: #52399
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

marco-ippolito pushed a commit that referenced this pull request

May 2, 2024
Co-authored-by: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #52401
Fixes: #52399
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

marco-ippolito pushed a commit that referenced this pull request

May 3, 2024
Co-authored-by: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #52401
Fixes: #52399
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>