Home Original page

lib: replace string prototype usage with alternatives by avivkeller · Pull Request #52440 · nodejs/node

@nodejs-github-bot added the needs-ci

PRs that need a full CI run.

label

Apr 9, 2024

Uzlopak

Uzlopak

mcollina

@avivkeller

@avivkeller avivkeller changed the title lib: use StringPrototypeStartsWith in place of .startsWith lib: replace string prototype usage with alternatives

Apr 10, 2024

H4ad

H4ad approved these changes Apr 10, 2024

benjamingr

benjamingr

rluvaton

RafaelGSS

@aduh95 aduh95 added author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

commit-queue

Add this label to land a pull request using GitHub Actions.

labels

Apr 11, 2024

aduh95 pushed a commit that referenced this pull request

Apr 29, 2024 
PR-URL: #52440
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

marco-ippolito pushed a commit that referenced this pull request

May 2, 2024 
PR-URL: #52440
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

marco-ippolito pushed a commit that referenced this pull request

May 3, 2024 
PR-URL: #52440
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>