Home Original page

src: sync NODE_REPL_EXTERNAL_MODULE and kDisableNodeOptionsEnv by RafaelGSS · Pull Request #52905 · nodejs/node

@nodejs-github-bot nodejs-github-bot added c++

Issues and PRs that require attention from people who are familiar with C++.

needs-ci

PRs that need a full CI run.

labels

May 8, 2024

@avivkeller avivkeller added the repl

Issues and PRs related to the REPL subsystem.

label

May 8, 2024

@github-actions github-actions bot added request-ci-failed

An error occurred while starting CI via request-ci label, and manual interventon is needed.

and removed request-ci

Add this label to start a Jenkins CI on a PR.

labels

May 8, 2024

@RafaelGSS RafaelGSS removed the request-ci-failed

An error occurred while starting CI via request-ci label, and manual interventon is needed.

label

May 9, 2024

Trott

juanarbol

StefanStojanovic added a commit to JaneaSystems/node that referenced this pull request

May 27, 2024 
2 PRs that landed independently caused this issue which makes every
native suites run in CI fail on Windows. This is just a quick patch to
unblock the CI.

Refs: nodejs#52905
Refs: nodejs#52646

StefanStojanovic added a commit to JaneaSystems/node that referenced this pull request

May 27, 2024 
2 PRs that landed independently caused this issue which makes every
native suites run in CI fail on Windows. This is just a quick patch to
unblock the CI.

Refs: nodejs#52905
Refs: nodejs#52646

nodejs-github-bot pushed a commit that referenced this pull request

May 27, 2024 
2 PRs that landed independently caused this issue which makes every
native suites run in CI fail on Windows. This is just a quick patch to
unblock the CI.

Refs: #52905
Refs: #52646
PR-URL: #53173
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

targos pushed a commit that referenced this pull request

Jun 1, 2024 
PR-URL: #52905
Fixes: #51227
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

targos pushed a commit that referenced this pull request

Jun 1, 2024 
2 PRs that landed independently caused this issue which makes every
native suites run in CI fail on Windows. This is just a quick patch to
unblock the CI.

Refs: #52905
Refs: #52646
PR-URL: #53173
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

sophoniie pushed a commit to sophoniie/node that referenced this pull request

Jun 20, 2024 
PR-URL: nodejs#52905
Fixes: nodejs#51227
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

sophoniie pushed a commit to sophoniie/node that referenced this pull request

Jun 20, 2024 
2 PRs that landed independently caused this issue which makes every
native suites run in CI fail on Windows. This is just a quick patch to
unblock the CI.

Refs: nodejs#52905
Refs: nodejs#52646
PR-URL: nodejs#53173
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

bmeck pushed a commit to bmeck/node that referenced this pull request

Jun 22, 2024 
PR-URL: nodejs#52905
Fixes: nodejs#51227
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

bmeck pushed a commit to bmeck/node that referenced this pull request

Jun 22, 2024 
2 PRs that landed independently caused this issue which makes every
native suites run in CI fail on Windows. This is just a quick patch to
unblock the CI.

Refs: nodejs#52905
Refs: nodejs#52646
PR-URL: nodejs#53173
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

marco-ippolito pushed a commit that referenced this pull request

Jul 19, 2024 
PR-URL: #52905
Fixes: #51227
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

marco-ippolito pushed a commit that referenced this pull request

Jul 19, 2024 
2 PRs that landed independently caused this issue which makes every
native suites run in CI fail on Windows. This is just a quick patch to
unblock the CI.

Refs: #52905
Refs: #52646
PR-URL: #53173
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

marco-ippolito pushed a commit that referenced this pull request

Jul 19, 2024 
PR-URL: #52905
Fixes: #51227
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

marco-ippolito pushed a commit that referenced this pull request

Jul 19, 2024 
2 PRs that landed independently caused this issue which makes every
native suites run in CI fail on Windows. This is just a quick patch to
unblock the CI.

Refs: #52905
Refs: #52646
PR-URL: #53173
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>