Home Original page

build: fix the extra whitespace before NINJIA_ARGS by jakecastelli · Pull Request #53181 · nodejs/node

@nodejs-github-bot added build

Issues and PRs related to build files or the CI.

needs-ci

PRs that need a full CI run.

labels

May 28, 2024

@anonrig anonrig added fast-track

PRs that do not need to wait for 72 hours to land.

author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

request-ci

Add this label to start a Jenkins CI on a PR.

labels

May 28, 2024

tniessen

lpinca

lpinca previously approved these changes May 28, 2024

targos

@jakecastelli jakecastelli changed the title build: passing -j number into ninja build: fix the extra whitespace before NINJIA_ARGS

May 28, 2024

@jakecastelli

@H4ad H4ad added the commit-queue

Add this label to land a pull request using GitHub Actions.

label

Jun 8, 2024

H4ad

H4ad approved these changes Jun 8, 2024

@H4ad H4ad added commit-queue

Add this label to land a pull request using GitHub Actions.

and removed commit-queue-failed

An error occurred while landing this pull request using GitHub Actions.

labels

Jun 8, 2024

targos pushed a commit that referenced this pull request

Jun 20, 2024 
PR-URL: #53181
Fixes: #53176
Refs: #53176
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>

sophoniie pushed a commit to sophoniie/node that referenced this pull request

Jun 20, 2024 
PR-URL: nodejs#53181
Fixes: nodejs#53176
Refs: nodejs#53176
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>

bmeck pushed a commit to bmeck/node that referenced this pull request

Jun 22, 2024 
PR-URL: nodejs#53181
Fixes: nodejs#53176
Refs: nodejs#53176
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>

marco-ippolito pushed a commit that referenced this pull request

Jul 19, 2024 
PR-URL: #53181
Fixes: #53176
Refs: #53176
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>

marco-ippolito pushed a commit that referenced this pull request

Jul 19, 2024 
PR-URL: #53181
Fixes: #53176
Refs: #53176
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>