Home Original page

test: fix test-http-server-keepalive-req-gc by targos · Pull Request #53292 · nodejs/node

@etiennep-chromium @targos 

This changes adds a second explicit gc call in the test. Without this
call, the test relies on gc eventually happening based, since the
first call doesn't free the object.
Relying on gc to eventually happen prevents changing GC heuristics
unrelated to this test.
The gc call is async; otherwise doing multiple sync GCs doesn't free
the object.

@targos added the commit-queue-rebase

Add this label to allow the Commit Queue to land a PR in several commits.

label

Jun 3, 2024

@targos targos added the commit-queue

Add this label to land a pull request using GitHub Actions.

label

Jun 10, 2024

@targos targos added commit-queue

Add this label to land a pull request using GitHub Actions.

and removed commit-queue-failed

An error occurred while landing this pull request using GitHub Actions.

labels

Jun 10, 2024

nodejs-github-bot pushed a commit that referenced this pull request

Jun 10, 2024 
This changes adds a second explicit gc call in the test. Without this
call, the test relies on gc eventually happening based, since the
first call doesn't free the object.
Relying on gc to eventually happen prevents changing GC heuristics
unrelated to this test.
The gc call is async; otherwise doing multiple sync GCs doesn't free
the object.

PR-URL: #53292
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

targos pushed a commit that referenced this pull request

Jun 20, 2024 
This changes adds a second explicit gc call in the test. Without this
call, the test relies on gc eventually happening based, since the
first call doesn't free the object.
Relying on gc to eventually happen prevents changing GC heuristics
unrelated to this test.
The gc call is async; otherwise doing multiple sync GCs doesn't free
the object.

PR-URL: #53292
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

sophoniie pushed a commit to sophoniie/node that referenced this pull request

Jun 20, 2024 
This changes adds a second explicit gc call in the test. Without this
call, the test relies on gc eventually happening based, since the
first call doesn't free the object.
Relying on gc to eventually happen prevents changing GC heuristics
unrelated to this test.
The gc call is async; otherwise doing multiple sync GCs doesn't free
the object.

PR-URL: nodejs#53292
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

bmeck pushed a commit to bmeck/node that referenced this pull request

Jun 22, 2024 
This changes adds a second explicit gc call in the test. Without this
call, the test relies on gc eventually happening based, since the
first call doesn't free the object.
Relying on gc to eventually happen prevents changing GC heuristics
unrelated to this test.
The gc call is async; otherwise doing multiple sync GCs doesn't free
the object.

PR-URL: nodejs#53292
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

marco-ippolito pushed a commit that referenced this pull request

Jul 19, 2024 
This changes adds a second explicit gc call in the test. Without this
call, the test relies on gc eventually happening based, since the
first call doesn't free the object.
Relying on gc to eventually happen prevents changing GC heuristics
unrelated to this test.
The gc call is async; otherwise doing multiple sync GCs doesn't free
the object.

PR-URL: #53292
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

marco-ippolito pushed a commit that referenced this pull request

Jul 19, 2024 
This changes adds a second explicit gc call in the test. Without this
call, the test relies on gc eventually happening based, since the
first call doesn't free the object.
Relying on gc to eventually happen prevents changing GC heuristics
unrelated to this test.
The gc call is async; otherwise doing multiple sync GCs doesn't free
the object.

PR-URL: #53292
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>