deps: update V8 to 12.7 by targos · Pull Request #53651 · nodejs/node

@targos added the semver-major

PRs that contain breaking changes and should be released in the next major version.

label

Jun 30, 2024

targos added a commit to targos/node that referenced this pull request

Jul 14, 2024
It is running on ubuntu-20.04, which will inevitably be removed from
GitHub actions at some point. Attempts to upgrade it to ubuntu-22.04
and ubuntu-24.04 have failed.

It is now blocking V8 updates because of errors that happen only with
the `test-asan` job.

Refs: nodejs#52374
Refs: nodejs#53651 (comment)

nodejs-github-bot pushed a commit that referenced this pull request

Jul 16, 2024
It is running on ubuntu-20.04, which will inevitably be removed from
GitHub actions at some point. Attempts to upgrade it to ubuntu-22.04
and ubuntu-24.04 have failed.

It is now blocking V8 updates because of errors that happen only with
the `test-asan` job.

Refs: #52374
Refs: #53651 (comment)
PR-URL: #53844
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@targos

@targos

@targos

dllexport introduces issues when compiling with MSVC.

PR-URL: nodejs#47251
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
It introduces process hangs on some platforms because Node.js doesn't
tear down V8 correctly.
Disable it while we work on a solution.

Refs: nodejs#47297
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=13902
PR-URL: nodejs#47450
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@targos

Original commit message:

    [heap] Fix allocation tracker line end retrieval

    Tests in NodeJS with DCHECK enabled were failing because of two
    different problems:
    - One was that we were also disallowing heap allocations in the
    serialization stage. But NodeJS tests process the heap snapshot
    result in JS, so all those were broken.
    - But, also, the code that would retrieve from line ends would assume
    all the scripts populated line ends in the snapshot. But this was
    wrong. To fix it, this patch adds another storage of the line ends
    in the allocation tracker. This storage needs to keep weak references
    to the scripts so we do not leak the line ends data when scripts are
    disposed.

    This change keeps a weak reference to the scripts so, when they are
    freed, the line ends cache is also freed as it is not useful anymore.

    Node issue: nodejs/node-v8#282

    Change-Id: I4314d707903175f0005893e9aa06d3ae52fc57f8
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5531355
    Commit-Queue: José Dapena Paz <jdapena@igalia.com>
    Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
    Reviewed-by: Simon Zünd <szuend@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#94418}

Refs: v8/v8@058870c

@targos

@fdoray @targos

@LeszekSwirski @targos

@targos

@targos

As V8 has moved away from wrapper-descriptor-based CppHeap, this
patch:

1. Create the CppHeap without using wrapper descriptors.
2. Deprecates node::SetCppgcReference() in favor of
   v8::Object::Wrap() since the wrapper descriptor is no longer
   relevant. It is still kept as a compatibility layer for addons
   that need to also work on Node.js versions without
   v8::Object::Wrap().

ehsankhfr pushed a commit to ehsankhfr/node that referenced this pull request

Jul 18, 2024
It is running on ubuntu-20.04, which will inevitably be removed from
GitHub actions at some point. Attempts to upgrade it to ubuntu-22.04
and ubuntu-24.04 have failed.

It is now blocking V8 updates because of errors that happen only with
the `test-asan` job.

Refs: nodejs#52374
Refs: nodejs#53651 (comment)
PR-URL: nodejs#53844
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@richardlau

Add/remove abseil files introduced by V8 12.7 update found by:
```
git diff-tree --no-commit-id --name-status 0ec8f7e -r | grep '^[AD].*abseil.*'
```

@targos

targos added a commit that referenced this pull request

Jul 28, 2024
It is running on ubuntu-20.04, which will inevitably be removed from
GitHub actions at some point. Attempts to upgrade it to ubuntu-22.04
and ubuntu-24.04 have failed.

It is now blocking V8 updates because of errors that happen only with
the `test-asan` job.

Refs: #52374
Refs: #53651 (comment)
PR-URL: #53844
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

marco-ippolito pushed a commit that referenced this pull request

Aug 19, 2024
It is running on ubuntu-20.04, which will inevitably be removed from
GitHub actions at some point. Attempts to upgrade it to ubuntu-22.04
and ubuntu-24.04 have failed.

It is now blocking V8 updates because of errors that happen only with
the `test-asan` job.

Refs: #52374
Refs: #53651 (comment)
PR-URL: #53844
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

marco-ippolito pushed a commit that referenced this pull request

Aug 19, 2024
It is running on ubuntu-20.04, which will inevitably be removed from
GitHub actions at some point. Attempts to upgrade it to ubuntu-22.04
and ubuntu-24.04 have failed.

It is now blocking V8 updates because of errors that happen only with
the `test-asan` job.

Refs: #52374
Refs: #53651 (comment)
PR-URL: #53844
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

marco-ippolito pushed a commit that referenced this pull request

Aug 19, 2024
It is running on ubuntu-20.04, which will inevitably be removed from
GitHub actions at some point. Attempts to upgrade it to ubuntu-22.04
and ubuntu-24.04 have failed.

It is now blocking V8 updates because of errors that happen only with
the `test-asan` job.

Refs: #52374
Refs: #53651 (comment)
PR-URL: #53844
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>