Home Original page

tools: apply custom buffer lint rule to /lib only by Trott · Pull Request #5371 · nodejs/node

@Trott 

The lint rule is there to avoid a circular-dependency issue that only
applies to `/lib`. In preparation for linting `/benchmark`, apply that
rule to `/lib` only to avoid churn in `/benchmark`.

Refs: nodejs#3983 (comment)

@Trott added buffer

Issues and PRs related to the buffer subsystem.

tools

Issues and PRs related to the tools directory.

labels

Feb 22, 2016

Trott added a commit to Trott/io.js that referenced this pull request

Feb 25, 2016 
The lint rule is there to avoid a circular-dependency issue that only
applies to `/lib`. In preparation for linting `/benchmark`, apply that
rule to `/lib` only to avoid churn in `/benchmark`.

Refs: nodejs#3983 (comment)
PR-URL: nodejs#5371
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>

rvagg pushed a commit that referenced this pull request

Feb 27, 2016 
The lint rule is there to avoid a circular-dependency issue that only
applies to `/lib`. In preparation for linting `/benchmark`, apply that
rule to `/lib` only to avoid churn in `/benchmark`.

Refs: #3983 (comment)
PR-URL: #5371
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>

rvagg pushed a commit that referenced this pull request

Feb 27, 2016 
The lint rule is there to avoid a circular-dependency issue that only
applies to `/lib`. In preparation for linting `/benchmark`, apply that
rule to `/lib` only to avoid churn in `/benchmark`.

Refs: #3983 (comment)
PR-URL: #5371
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>

MylesBorins pushed a commit that referenced this pull request

Mar 17, 2016 
The lint rule is there to avoid a circular-dependency issue that only
applies to `/lib`. In preparation for linting `/benchmark`, apply that
rule to `/lib` only to avoid churn in `/benchmark`.

Refs: #3983 (comment)
PR-URL: #5371
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>

MylesBorins pushed a commit that referenced this pull request

Mar 21, 2016 
The lint rule is there to avoid a circular-dependency issue that only
applies to `/lib`. In preparation for linting `/benchmark`, apply that
rule to `/lib` only to avoid churn in `/benchmark`.

Refs: #3983 (comment)
PR-URL: #5371
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>

@aqrln aqrln mentioned this pull request

Jun 21, 2017

@Trott Trott deleted the bench-lint branch

January 13, 2022 22:42