Home Original page

src: use Maybe<void> in SecureContext by tniessen · Pull Request #53883 · nodejs/node

@tniessen 

With recent versions of V8, it is not necessary to use Maybe<bool>
anymore. This changes member functions of SecureContext to use
Maybe<void> instead.

@tniessen added the request-ci

Add this label to start a Jenkins CI on a PR.

label

Jul 17, 2024

@nodejs-github-bot nodejs-github-bot added c++

Issues and PRs that require attention from people who are familiar with C++.

crypto

Issues and PRs related to the crypto subsystem.

needs-ci

PRs that need a full CI run.

labels

Jul 17, 2024

addaleax

@tniessen tniessen added author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

commit-queue

Add this label to land a pull request using GitHub Actions.

labels

Jul 17, 2024

targos pushed a commit that referenced this pull request

Jul 28, 2024 
With recent versions of V8, it is not necessary to use Maybe<bool>
anymore. This changes member functions of SecureContext to use
Maybe<void> instead.

PR-URL: #53883
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>