test_runner: make `mock.module`'s `specifier` consistent with `import()` by aduh95 · Pull Request #54416

test_runner: make `mock.module`'s `specifier` consistent with `import()` by aduh95 · Pull Request #54416 · nodejs/node

The previous implementation was trying to follow both `require` and
`import` conventions. It is not practical to try to follow both,
and aligning with `import()` seems to be what makes the most sense.

added needs-ci

PRs that need a full CI run.

test_runner

Issues and PRs related to the test runner subsystem.

labels

Aug 16, 2024

aduh95 added author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

request-ci

Add this label to start a Jenkins CI on a PR.

labels

Aug 17, 2024

aduh95 added the commit-queue

Add this label to land a pull request using GitHub Actions.

label

Aug 20, 2024

RafaelGSS pushed a commit that referenced this pull request

Aug 25, 2024

The previous implementation was trying to follow both `require` and
`import` conventions. It is not practical to try to follow both,
and aligning with `import()` seems to be what makes the most sense.

PR-URL: #54416
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

targos added the dont-land-on-v20.x

PRs that should not land on the v20.x-staging branch and should not be released in v20.x.

label

Sep 21, 2024

reillylm added a commit to reillylm/DefinitelyTyped that referenced this pull request

Feb 6, 2026

reillylm added a commit to reillylm/DefinitelyTyped that referenced this pull request

Feb 6, 2026