Home Original page

test_runner: finish build phase before running tests by cjihrig · Pull Request #54423 · nodejs/node

@nodejs-github-bot added needs-ci

PRs that need a full CI run.

test_runner

Issues and PRs related to the test runner subsystem.

labels

Aug 17, 2024

benjamingr

mcollina

@cjihrig 

This commit updates the test runner to wait for suites to finish
building before starting any tests. This is necessary when test
filtering is enabled, as suites may transition from filtered to
not filtered depending on what is inside of them.

Fixes: nodejs#54084
Fixes: nodejs#54154

@cjihrig cjihrig added author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

commit-queue

Add this label to land a pull request using GitHub Actions.

and removed needs-ci

PRs that need a full CI run.

labels

Aug 18, 2024

jakecastelli

@cjihrig cjihrig deleted the filter-suite-order branch

August 20, 2024 11:14

RafaelGSS pushed a commit that referenced this pull request

Aug 25, 2024 
This commit updates the test runner to wait for suites to finish
building before starting any tests. This is necessary when test
filtering is enabled, as suites may transition from filtered to
not filtered depending on what is inside of them.

Fixes: #54084
Fixes: #54154
PR-URL: #54423
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>

@targos targos added the dont-land-on-v20.x

PRs that should not land on the v20.x-staging branch and should not be released in v20.x.

label

Sep 21, 2024