fs: fix fd leak in ReadStream.destroy() by jonathanong · Pull Request #56 · nodejs/node

dacappo pushed a commit to SAP-archive/node-rasp that referenced this pull request

Nov 29, 2018
* [Refactoring] change taint to _taint on buffer

* [Refactor] Added _taint in unit tests

* [Feature] Added method for buffer

* [Test] Buffer.new() test for each encoding

* [Test] Buffer.from() tests

* [Test] Buffer.new() tests

* [Test] Buffer.new() tests for one string + each encoding

* [Test] Buffer.new() tests for concatenated ascii and utf8 encoding

* [Test] Buffer.new() test enhanced for utf8 encoding

* [Test] Buffer.new() tests for hex (ascii) encoding

* [Test] Buffer.new() removed bug in unit tests

* [Test] Buffer.new() tests for hex encoding with utf8 character

* [Test] Buffer.new() unit tests for base64 encoding

* [Test] Buffer.new() unit tests for base64 unicode encoding

* [Test] Buffer.new() refactoring for utf8 + ascii encoding

* [Buffer] Reactor taint propagation toString and slice

* [Buffer] Remove previously inserted newlines

* [Buffer] Taint propagation for Buffer.prototype.toString('hex')

* [Test] Buffer.new() unit tests for utf8 encoding

* [Feature] Buffer.alloc() keep taint

* [Feature] Buffer.alloc() keep (sub-)taint for hex encoding

* [Test] Buffer.fill() unit tests

* [Feature] Buffer.write() ascii/uft8 taint propagation

* [Test] Buffer.concat() unit tests

* Buffer.write() refactored

* Â[Feature] apply Taint to Partial Buffer

* [Feature] Keep taint outsite taint ranges for write/fill

* [Fix] Buffer.concat() taint propagation

* [Merge] buffer refactoring

* [Refactoring] Final buffer status

* [Feature] Final status of buffer

* [Feature] Final refactored buffer api status

dacappo pushed a commit to SAP-archive/node-rasp that referenced this pull request

Dec 3, 2018
* [Refactoring] change taint to _taint on buffer

* [Refactor] Added _taint in unit tests

* [Feature] Added method for buffer

* [Test] Buffer.new() test for each encoding

* [Test] Buffer.from() tests

* [Test] Buffer.new() tests

* [Test] Buffer.new() tests for one string + each encoding

* [Test] Buffer.new() tests for concatenated ascii and utf8 encoding

* [Test] Buffer.new() test enhanced for utf8 encoding

* [Test] Buffer.new() tests for hex (ascii) encoding

* [Test] Buffer.new() removed bug in unit tests

* [Test] Buffer.new() tests for hex encoding with utf8 character

* [Test] Buffer.new() unit tests for base64 encoding

* [Test] Buffer.new() unit tests for base64 unicode encoding

* [Test] Buffer.new() refactoring for utf8 + ascii encoding

* [Buffer] Reactor taint propagation toString and slice

* [Buffer] Remove previously inserted newlines

* [Buffer] Taint propagation for Buffer.prototype.toString('hex')

* [Test] Buffer.new() unit tests for utf8 encoding

* [Feature] Buffer.alloc() keep taint

* [Feature] Buffer.alloc() keep (sub-)taint for hex encoding

* [Test] Buffer.fill() unit tests

* [Feature] Buffer.write() ascii/uft8 taint propagation

* [Test] Buffer.concat() unit tests

* Buffer.write() refactored

* Â[Feature] apply Taint to Partial Buffer

* [Feature] Keep taint outsite taint ranges for write/fill

* [Fix] Buffer.concat() taint propagation

* [Merge] buffer refactoring

* [Refactoring] Final buffer status

* [Feature] Final status of buffer

* [Feature] Final refactored buffer api status

dacappo pushed a commit to SAP-archive/node-rasp that referenced this pull request

Jan 24, 2019
* [Refactoring] change taint to _taint on buffer

* [Refactor] Added _taint in unit tests

* [Feature] Added method for buffer

* [Test] Buffer.new() test for each encoding

* [Test] Buffer.from() tests

* [Test] Buffer.new() tests

* [Test] Buffer.new() tests for one string + each encoding

* [Test] Buffer.new() tests for concatenated ascii and utf8 encoding

* [Test] Buffer.new() test enhanced for utf8 encoding

* [Test] Buffer.new() tests for hex (ascii) encoding

* [Test] Buffer.new() removed bug in unit tests

* [Test] Buffer.new() tests for hex encoding with utf8 character

* [Test] Buffer.new() unit tests for base64 encoding

* [Test] Buffer.new() unit tests for base64 unicode encoding

* [Test] Buffer.new() refactoring for utf8 + ascii encoding

* [Buffer] Reactor taint propagation toString and slice

* [Buffer] Remove previously inserted newlines

* [Buffer] Taint propagation for Buffer.prototype.toString('hex')

* [Test] Buffer.new() unit tests for utf8 encoding

* [Feature] Buffer.alloc() keep taint

* [Feature] Buffer.alloc() keep (sub-)taint for hex encoding

* [Test] Buffer.fill() unit tests

* [Feature] Buffer.write() ascii/uft8 taint propagation

* [Test] Buffer.concat() unit tests

* Buffer.write() refactored

* Â[Feature] apply Taint to Partial Buffer

* [Feature] Keep taint outsite taint ranges for write/fill

* [Fix] Buffer.concat() taint propagation

* [Merge] buffer refactoring

* [Refactoring] Final buffer status

* [Feature] Final status of buffer

* [Feature] Final refactored buffer api status

This was referenced

Jul 17, 2020

targos added a commit to targos/node that referenced this pull request

Apr 17, 2021
Original commit message:

    Merged: [deoptimizer] Stricter checks during deoptimization

    Revision: 506e893b812e03dbebe34b11d8aa9d4eb6869d89

    BUG=chromium:1161357
    NOTRY=true
    NOPRESUBMIT=true
    NOTREECHECKS=true
    R=​mythria@chromium.org

    (cherry picked from commit 44d052c19df0801fafdf2be54c899db65e79c67a)

    Change-Id: I97b69ae11d85bc0acd4a0c7bd28e1b692433de80
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2616219
    Reviewed-by: Mythri Alle <mythria@chromium.org>
    Commit-Queue: Georg Neis <neis@chromium.org>
    Cr-Original-Commit-Position: refs/branch-heads/8.8@{#23}
    Cr-Original-Branched-From: 2dbcdc105b963ee2501c82139eef7e0603977ff0-refs/heads/8.8.278@{#1}
    Cr-Original-Branched-From: 366d30c99049b3f1c673f8a93deb9f879d0fa9f0-refs/heads/master@{#71094}
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2649571
    Reviewed-by: Victor-Gabriel Savu <vsavu@google.com>
    Commit-Queue: Achuith Bhandarkar <achuith@chromium.org>
    Cr-Commit-Position: refs/branch-heads/8.6@{nodejs#56}
    Cr-Branched-From: a64aed2333abf49e494d2a5ce24bbd14fff19f60-refs/heads/8.6.395@{#1}
    Cr-Branched-From: a626bc036236c9bf92ac7b87dc40c9e538b087e3-refs/heads/master@{#69472}

Refs: v8/v8@ad2c5da

targos added a commit to targos/node that referenced this pull request

Apr 27, 2021
Original commit message:

    Merged: [deoptimizer] Stricter checks during deoptimization

    Revision: 506e893b812e03dbebe34b11d8aa9d4eb6869d89

    BUG=chromium:1161357
    NOTRY=true
    NOPRESUBMIT=true
    NOTREECHECKS=true
    R=​mythria@chromium.org

    (cherry picked from commit 44d052c19df0801fafdf2be54c899db65e79c67a)

    Change-Id: I97b69ae11d85bc0acd4a0c7bd28e1b692433de80
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2616219
    Reviewed-by: Mythri Alle <mythria@chromium.org>
    Commit-Queue: Georg Neis <neis@chromium.org>
    Cr-Original-Commit-Position: refs/branch-heads/8.8@{#23}
    Cr-Original-Branched-From: 2dbcdc105b963ee2501c82139eef7e0603977ff0-refs/heads/8.8.278@{#1}
    Cr-Original-Branched-From: 366d30c99049b3f1c673f8a93deb9f879d0fa9f0-refs/heads/master@{#71094}
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2649571
    Reviewed-by: Victor-Gabriel Savu <vsavu@google.com>
    Commit-Queue: Achuith Bhandarkar <achuith@chromium.org>
    Cr-Commit-Position: refs/branch-heads/8.6@{nodejs#56}
    Cr-Branched-From: a64aed2333abf49e494d2a5ce24bbd14fff19f60-refs/heads/8.6.395@{#1}
    Cr-Branched-From: a626bc036236c9bf92ac7b87dc40c9e538b087e3-refs/heads/master@{#69472}

Refs: v8/v8@ad2c5da

targos added a commit that referenced this pull request

Apr 30, 2021
Original commit message:

    Merged: [deoptimizer] Stricter checks during deoptimization

    Revision: 506e893b812e03dbebe34b11d8aa9d4eb6869d89

    BUG=chromium:1161357
    NOTRY=true
    NOPRESUBMIT=true
    NOTREECHECKS=true
    R=​mythria@chromium.org

    (cherry picked from commit 44d052c19df0801fafdf2be54c899db65e79c67a)

    Change-Id: I97b69ae11d85bc0acd4a0c7bd28e1b692433de80
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2616219
    Reviewed-by: Mythri Alle <mythria@chromium.org>
    Commit-Queue: Georg Neis <neis@chromium.org>
    Cr-Original-Commit-Position: refs/branch-heads/8.8@{#23}
    Cr-Original-Branched-From: 2dbcdc105b963ee2501c82139eef7e0603977ff0-refs/heads/8.8.278@{#1}
    Cr-Original-Branched-From: 366d30c99049b3f1c673f8a93deb9f879d0fa9f0-refs/heads/master@{#71094}
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2649571
    Reviewed-by: Victor-Gabriel Savu <vsavu@google.com>
    Commit-Queue: Achuith Bhandarkar <achuith@chromium.org>
    Cr-Commit-Position: refs/branch-heads/8.6@{#56}
    Cr-Branched-From: a64aed2333abf49e494d2a5ce24bbd14fff19f60-refs/heads/8.6.395@{#1}
    Cr-Branched-From: a626bc036236c9bf92ac7b87dc40c9e538b087e3-refs/heads/master@{#69472}

Refs: v8/v8@ad2c5da

PR-URL: #38275
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>

This was referenced

Sep 13, 2021

@s4sc s4sc mentioned this pull request

May 14, 2022