Home Original page

src: remove NonCopyableMaybe by tniessen · Pull Request #58168 · nodejs/node

@tniessen

@tniessen added the c++

Issues and PRs that require attention from people who are familiar with C++.

label

May 4, 2025

BridgeAR

@BridgeAR BridgeAR added author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

request-ci

Add this label to start a Jenkins CI on a PR.

labels

May 4, 2025

juanarbol

marco-ippolito

@Flarna Flarna added the commit-queue

Add this label to land a pull request using GitHub Actions.

label

May 5, 2025

bjohansebas

targos pushed a commit that referenced this pull request

May 16, 2025 
I added this class in 823d86c in 2018
when we did not yet use `std::optional`. The last uses were removed in
5b9bf39, so remove it.

Refs: #24234
Refs: #55368
PR-URL: #58168
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

aduh95 pushed a commit that referenced this pull request

Jun 10, 2025 
I added this class in 823d86c in 2018
when we did not yet use `std::optional`. The last uses were removed in
5b9bf39, so remove it.

Refs: #24234
Refs: #55368
PR-URL: #58168
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>