test: reduce the use of private symbols in test-events-once.js by kt3k · Pull Request #58685

test: reduce the use of private symbols in test-events-once.js by kt3k · Pull Request #58685 · nodejs/node

Conversation

This PR reduces the usage of private symbol kEvents in test/parallel/test-events-once.js.

It'd be good to avoid using private items to make future refactoring easier

kt3k changed the title ~~test: reduce the use of private symbols in test/parallel/test-events-once.js~~ test: reduce the use of private symbols in test-events-once.js

Jun 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.16%. Comparing base (5e1537c) to head (69252ed).
Report is 18 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #58685   +/-   ##
=======================================
  Coverage   90.16%   90.16%           
=======================================
  Files         637      637           
  Lines      188098   188098           
  Branches    36905    36896    -9     
=======================================
+ Hits       169601   169605    +4     
- Misses      11231    11236    +5     
+ Partials     7266     7257    -9

see 29 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

aduh95 added author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

commit-queue

Add this label to land a pull request using GitHub Actions.

labels

Jun 15, 2025

kt3k deleted the test-reduce-use-of-private-symbol branch

June 16, 2025 00:57

targos pushed a commit that referenced this pull request

Jun 16, 2025

PR-URL: #58685
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

This was referenced

Jun 23, 2025

aduh95 pushed a commit that referenced this pull request

Jul 21, 2025

PR-URL: #58685
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

aduh95 pushed a commit that referenced this pull request

Jul 24, 2025

PR-URL: #58685
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

Conversation

Codecov Report

Labels