Home Original page

timers: fixing API refs to use safe internal refs by Trott · Pull Request #5882 · nodejs/node

@Trott added timers

Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.

lts-watch-v4.x labels

Mar 23, 2016

@getify @Trott 

Added safe internal references for 'clearTimeout(..)', 'active(..)', and
'unenroll(..)'. Changed various API refs from 'export.*' to use these
safe internal references.

Now, overwriting the global API identifiers does not create potential
breakage and/or race conditions. See Issue nodejs#2493.

@Trott

@Trott Trott mentioned this pull request

Mar 27, 2016

Trott pushed a commit to Trott/io.js that referenced this pull request

Mar 28, 2016 
Added safe internal references for 'clearTimeout(..)', 'active(..)', and
'unenroll(..)'. Changed various API refs from 'export.*' to use these
safe internal references.

Now, overwriting the global API identifiers does not create potential
breakage and/or race conditions. See Issue nodejs#2493.

PR-URL: nodejs#5882
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Fixes: nodejs#2493

Trott added a commit to Trott/io.js that referenced this pull request

Mar 28, 2016 
PR-URL: nodejs#5882
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

evanlucas pushed a commit that referenced this pull request

Mar 30, 2016 
Added safe internal references for 'clearTimeout(..)', 'active(..)', and
'unenroll(..)'. Changed various API refs from 'export.*' to use these
safe internal references.

Now, overwriting the global API identifiers does not create potential
breakage and/or race conditions. See Issue #2493.

PR-URL: #5882
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Fixes: #2493

evanlucas pushed a commit that referenced this pull request

Mar 30, 2016 
PR-URL: #5882
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

evanlucas pushed a commit that referenced this pull request

Mar 31, 2016 
Added safe internal references for 'clearTimeout(..)', 'active(..)', and
'unenroll(..)'. Changed various API refs from 'export.*' to use these
safe internal references.

Now, overwriting the global API identifiers does not create potential
breakage and/or race conditions. See Issue #2493.

PR-URL: #5882
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Fixes: #2493

evanlucas pushed a commit that referenced this pull request

Mar 31, 2016 
PR-URL: #5882
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

@Trott Trott deleted the fix-timers-api-refs branch

January 13, 2022 22:42