Home Original page

crypto: fix SHAKE128/256 breaking change introduced with OpenSSL 3.4 by panva · Pull Request #58942 · nodejs/node

@nodejs-github-bot added c++

Issues and PRs that require attention from people who are familiar with C++.

crypto

Issues and PRs related to the crypto subsystem.

needs-ci

PRs that need a full CI run.

labels

Jul 3, 2025

panva

panva

@panva panva marked this pull request as ready for review

July 3, 2025 10:18

@panva panva added the commit-queue-squash

Add this label to instruct the Commit Queue to squash all the PR commits into the first one.

label

Jul 3, 2025

aduh95

aduh95

aduh95

@panva panva mentioned this pull request

Jul 5, 2025

panva added a commit to panva/node that referenced this pull request

Jul 5, 2025 
Reverts: nodejs#56160
Fixes: nodejs#56159
Fixes: nodejs#58913
Refs: nodejs#58121
PR-URL: nodejs#58942
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

@panva panva deleted the xof-openssl34 branch

July 5, 2025 11:59

panva added a commit to panva/node that referenced this pull request

Jul 5, 2025 
Reverts: nodejs#56160
Fixes: nodejs#56159
Fixes: nodejs#58913
Refs: nodejs#58121
PR-URL: nodejs#58942
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

@panva panva mentioned this pull request

Jul 5, 2025

RafaelGSS pushed a commit that referenced this pull request

Jul 8, 2025 
Reverts: #56160
Fixes: #56159
Fixes: #58913
Refs: #58121
PR-URL: #58942
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

@panva panva mentioned this pull request

Jul 9, 2025

aduh95 pushed a commit to panva/node that referenced this pull request

Jul 21, 2025

codebytere added a commit to electron/electron that referenced this pull request

Aug 4, 2025

jkleinsc pushed a commit to electron/electron that referenced this pull request

Aug 4, 2025 
* chore: bump node in DEPS to v22.18.0

* crypto: fix inclusion of OPENSSL_IS_BORINGSSL define

nodejs/node#58845

* crypto: fix SHAKE128/256 breaking change introduced with OpenSSL 3.4

nodejs/node#58960

* permission: propagate permission model flags on spawn

nodejs/node#58853

* esm: syncify default path of ModuleLoader\.load

nodejs/node#57419

* src: remove fast API for InternalModuleStat

nodejs/node#58489

* src: simplify adding fast APIs to ExternalReferenceRegistry

nodejs/node#58896

* chore: fixup patch indices

* src: fix internalModuleStat v8 fast path

nodejs/node#58054

* test: add tests to ensure that node.1 is kept in sync with cli.md

nodejs/node#58878

* crypto: fix SHAKE128/256 breaking change introduced with OpenSSL 3.4

nodejs/node#58942

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

codebytere added a commit to electron/electron that referenced this pull request

Aug 5, 2025 
* chore: bump node in DEPS to v22.18.0

* crypto: fix inclusion of OPENSSL_IS_BORINGSSL define

nodejs/node#58845

* crypto: fix SHAKE128/256 breaking change introduced with OpenSSL 3.4

nodejs/node#58960

* permission: propagate permission model flags on spawn

nodejs/node#58853

* esm: syncify default path of ModuleLoader\.load

nodejs/node#57419

* src: remove fast API for InternalModuleStat

nodejs/node#58489

* src: simplify adding fast APIs to ExternalReferenceRegistry

nodejs/node#58896

* chore: fixup patch indices

* src: fix internalModuleStat v8 fast path

nodejs/node#58054

* test: add tests to ensure that node.1 is kept in sync with cli.md

nodejs/node#58878

* crypto: fix SHAKE128/256 breaking change introduced with OpenSSL 3.4

nodejs/node#58942

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

codebytere added a commit to electron/electron that referenced this pull request

Aug 5, 2025 
chore: bump node to v22.18.0 (main) (#47937)

* chore: bump node in DEPS to v22.18.0

* crypto: fix inclusion of OPENSSL_IS_BORINGSSL define

nodejs/node#58845

* crypto: fix SHAKE128/256 breaking change introduced with OpenSSL 3.4

nodejs/node#58960

* permission: propagate permission model flags on spawn

nodejs/node#58853

* esm: syncify default path of ModuleLoader\.load

nodejs/node#57419

* src: remove fast API for InternalModuleStat

nodejs/node#58489

* src: simplify adding fast APIs to ExternalReferenceRegistry

nodejs/node#58896

* chore: fixup patch indices

* src: fix internalModuleStat v8 fast path

nodejs/node#58054

* test: add tests to ensure that node.1 is kept in sync with cli.md

nodejs/node#58878

* crypto: fix SHAKE128/256 breaking change introduced with OpenSSL 3.4

nodejs/node#58942

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

marco-ippolito pushed a commit that referenced this pull request

Aug 14, 2025 
Reverts: #56160
Fixes: #56159
Fixes: #58913
Refs: #58121
PR-URL: #58942
Backport-PR-URL: #58961
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

marco-ippolito pushed a commit that referenced this pull request

Aug 25, 2025 
Reverts: #56160
Fixes: #56159
Fixes: #58913
Refs: #58121
PR-URL: #58942
Backport-PR-URL: #58961
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

marco-ippolito pushed a commit that referenced this pull request

Aug 27, 2025 
Reverts: #56160
Fixes: #56159
Fixes: #58913
Refs: #58121
PR-URL: #58942
Backport-PR-URL: #58961
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

marco-ippolito pushed a commit that referenced this pull request

Aug 27, 2025 
Reverts: #56160
Fixes: #56159
Fixes: #58913
Refs: #58121
PR-URL: #58942
Backport-PR-URL: #58961
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

kigh-ota pushed a commit to kigh-ota/electron that referenced this pull request

Sep 30, 2025 
* chore: bump node in DEPS to v22.18.0

* crypto: fix inclusion of OPENSSL_IS_BORINGSSL define

nodejs/node#58845

* crypto: fix SHAKE128/256 breaking change introduced with OpenSSL 3.4

nodejs/node#58960

* permission: propagate permission model flags on spawn

nodejs/node#58853

* esm: syncify default path of ModuleLoader\.load

nodejs/node#57419

* src: remove fast API for InternalModuleStat

nodejs/node#58489

* src: simplify adding fast APIs to ExternalReferenceRegistry

nodejs/node#58896

* chore: fixup patch indices

* src: fix internalModuleStat v8 fast path

nodejs/node#58054

* test: add tests to ensure that node.1 is kept in sync with cli.md

nodejs/node#58878

* crypto: fix SHAKE128/256 breaking change introduced with OpenSSL 3.4

nodejs/node#58942

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>