module: preserve symlinks when requiring by lamara · Pull Request #5950

module: preserve symlinks when requiring by lamara · Pull Request #5950 · nodejs/node

added module

Issues and PRs related to the module subsystem.

semver-major

PRs that contain breaking changes and should be released in the next major version.

labels

Mar 30, 2016

jasnell added a commit to jasnell/node that referenced this pull request

May 2, 2016

Adds a test case in the known-test cases to catch nodejs#5950
Adds a test to verify that circular symlinked deps do not recurse
forever.

jasnell added a commit to jasnell/node that referenced this pull request

May 3, 2016

Adds a test case in the known-test cases to catch nodejs#5950
Adds a test to verify that circular symlinked deps do not recurse
forever.

Gared mentioned this pull request

May 5, 2016

jasnell added a commit to jasnell/node that referenced this pull request

May 13, 2016

Add the `--preserve-symlinks` flag. This makes the changes added
in nodejs#5950 conditional. By default the old behavior is used. With
the flag set, symlinks are preserved, switching to the new
behavior. This should be considered to be a temporary solution
until we figure out how to solve the symlinked peer dependency
problem in a more general way that does not break everything
else.

Additional test cases are included.

jasnell added a commit that referenced this pull request

May 13, 2016

Add the `--preserve-symlinks` flag. This makes the changes added
in #5950 conditional. By default the old behavior is used. With
the flag set, symlinks are preserved, switching to the new
behavior. This should be considered to be a temporary solution
until we figure out how to solve the symlinked peer dependency
problem in a more general way that does not break everything
else.

Additional test cases are included.

PR-URL: #6537
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

evanlucas pushed a commit that referenced this pull request

May 17, 2016

Add the `--preserve-symlinks` flag. This makes the changes added
in #5950 conditional. By default the old behavior is used. With
the flag set, symlinks are preserved, switching to the new
behavior. This should be considered to be a temporary solution
until we figure out how to solve the symlinked peer dependency
problem in a more general way that does not break everything
else.

Additional test cases are included.

PR-URL: #6537
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>