2025-09-10, Version 24.8.0 (Current) by github-actions[bot] · Pull Request #59816 · nodejs/node

and others added 30 commits

August 28, 2025 08:38
PR-URL: #59608
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #59537
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
PR-URL: #59544
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
PR-URL: #59161
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
prevent adding timer to execution queue if clearInterval() called

PR-URL: #59479
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
PR-URL: #59080
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
PR-URL: #59616
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
This is now unused after
https://redirect.github.com/nodejs/node/pull/59473 and
and https://redirect.github.com/nodejs/node/pull/59323

PR-URL: #59619
Fixes: #59288
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Shelley Vohr <shelley.vohr@gmail.com>
Reviewed-By: Daniel Lemire <daniel@lemire.me>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
This allows tracking HTTP/2 calls through the Network tab of
Chrome DevTools for Node.js.

Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: #59611
Refs: #53946
Reviewed-By: Ryuhei Shima <shimaryuhei@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
PR-URL: #59601
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
PR-URL: #59607
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This does the same for `--shared-uvwasi` as #55886 does for `ada`,
`simdjson`, and `simdutf`.

Refs: #55886
PR-URL: #59622
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
The inspector command line flags should be allowed via NODE_OPTIONS,
though it should not be consumed when passed directly to the SEA.
This patch allows it to consume inspector flags from NODE_OPTIONS
and add tests for different behaviors.

PR-URL: #59568
Fixes: #51688
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Origin commit message:

    [loong64][codegen] Avoid memory access under stack pointer

    According to LoongArch ABI doc chapter 8.2:
      "Procedures must not assume the persistence on-stack data of which
       the addresses lie below the stack pointer."

    Change-Id: I92735e052227495ac9884c4290b57eaffbf905e1
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6786372
    Auto-Submit: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn>
    Reviewed-by: Matthias Liedtke <mliedtke@chromium.org>
    Commit-Queue: Matthias Liedtke <mliedtke@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#101634}

Refs: v8/v8@6b1b9bc
PR-URL: #59283
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
PR-URL: #59269
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
- Do not call `client.end()` to ensure that the socket is closed by the
  server.
- Remove the timer and send the empty line when the response is
  received.

Fixes: #59577
PR-URL: #59595
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
PR-URL: #59635
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
These tests are likely actual regressions introduced when the
monolithic test-fs-cp.mjs was marked as flaky and got ignored due
to the flaky status. They are now constantly failing the Windows
CI and require the CI to always be re-run on Windows when the job
is resumed. Simply skip them until someone fixes them, as there's
no point keep running these known regressions on Windows anymore.

PR-URL: #59637
Refs: #59636
Refs: #59408
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
PR-URL: #59642
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Split `module.link(linker)` into two synchronous step
`sourceTextModule.linkRequests()` and
`sourceTextModule.instantiate()`. This allows creating vm modules and
resolving the dependencies in a complete synchronous procedure.

This also makes `syntheticModule.link()` redundant. The link step for a
SyntheticModule is no-op and is already taken care in the constructor
by initializing the binding slots with the given export names.

PR-URL: #59000
Refs: #37648
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Fixes: #59326
PR-URL: #59579
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #59428
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
PR-URL: #59633
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
PR-URL: #59649
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
PR-URL: #59634
Fixes: #59555
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
The `nodejs.org` domain has now two TXT records.
Do not verify the exact number of records returned (only their shape),
and check that one of them is the SPF.

PR-URL: #59660
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
PR-URL: #59650
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Replace repetitive manual function type checking with the existing
validateFunction in multiple stream operator functions.

PR-URL: #59529
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Mattias Buelens <mattias@buelens.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

targos pushed a commit that referenced this pull request

Sep 10, 2025
Notable changes:

crypto:
  * (SEMVER-MINOR) support Ed448 and ML-DSA context parameter in node:crypto (Filip Skokan) #59570
  * (SEMVER-MINOR) support Ed448 and ML-DSA context parameter in Web Cryptography (Filip Skokan) #59570
  * (SEMVER-MINOR) add KMAC Web Cryptography algorithms (Filip Skokan) #59647
  * (SEMVER-MINOR) add Argon2 Web Cryptography algorithms (Filip Skokan) #59544
  * (SEMVER-MINOR) support SLH-DSA KeyObject, sign, and verify (Filip Skokan) #59537
inspector:
  * add http2 tracking support (Darshan Sen) #59611
worker:
  * (SEMVER-MINOR) add cpu profile APIs for worker (theanarkh) #59428

PR-URL: #59816
Call `V8::ExternalMemoryAccounter::Update` instead of
`V8::ExternalMemoryAccounter::Increase` to report memory difference to
V8

Calling `V8::ExternalMemoryAccounter::Increase` with a signed integer on
32-bit platforms causes instances where GC inside GC takes place leading
to a crash in certain cases.

During GC, native objects are destructed. In destructor for
`CompressionStream` class used by zlib, memory release information is
passed onto `V8::ExternalMemoryAccounter::Increase()` instead of
`V8::ExternalMemoryAccounter::Decrease()` which triggers V8's memory
limits, thus triggering GC inside GC which leads to crash.

Bug initially introduced in commit
1d5d7b6

For full report see https://hackerone.com/reports/3302484

PR-URL: #59623
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
PR-URL: #59707
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Adds a guard.

PR-URL: #59784
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Improved API and better performance:

```
url/urlpattern-parse.js n=100000 ... ***  11.59 %  ±0.96% ±1.28% ±1.66%
url/urlpattern-parse.js n=100000 ... ***   9.28 %  ±0.94% ±1.25% ±1.63%
url/urlpattern-parse.js n=100000 ... ***   6.97 %  ±0.97% ±1.29% ±1.70%
url/urlpattern-parse.js n=100000 ... ***   7.56 %  ±0.92% ±1.22% ±1.59%
url/urlpattern-test.js n=100000  ... ***   2.84 %  ±1.50% ±2.00% ±2.61%
url/urlpattern-test.js n=100000  ... ***   4.13 %  ±2.14% ±2.84% ±3.70%
url/urlpattern-test.js n=100000  ... ***   4.76 %  ±1.43% ±1.91% ±2.49%
url/urlpattern-test.js n=100000  ... ***   4.44 %  ±1.26% ±1.68% ±2.19%
```

PR-URL: #59802
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
PR-URL: #59837
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

targos pushed a commit that referenced this pull request

Sep 10, 2025
Notable changes:

crypto:
  * (SEMVER-MINOR) support Ed448 and ML-DSA context parameter in node:crypto (Filip Skokan) #59570
  * (SEMVER-MINOR) support Ed448 and ML-DSA context parameter in Web Cryptography (Filip Skokan) #59570
  * (SEMVER-MINOR) add KMAC Web Cryptography algorithms (Filip Skokan) #59647
  * (SEMVER-MINOR) add Argon2 Web Cryptography algorithms (Filip Skokan) #59544
  * (SEMVER-MINOR) support SLH-DSA KeyObject, sign, and verify (Filip Skokan) #59537
inspector:
  * add http2 tracking support (Darshan Sen) #59611
worker:
  * (SEMVER-MINOR) add cpu profile APIs for worker (theanarkh) #59428

PR-URL: #59816

targos pushed a commit that referenced this pull request

Sep 10, 2025
Notable changes:

crypto:
  * (SEMVER-MINOR) support Ed448 and ML-DSA context parameter in node:crypto (Filip Skokan) #59570
  * (SEMVER-MINOR) support Ed448 and ML-DSA context parameter in Web Cryptography (Filip Skokan) #59570
  * (SEMVER-MINOR) add KMAC Web Cryptography algorithms (Filip Skokan) #59647
  * (SEMVER-MINOR) add Argon2 Web Cryptography algorithms (Filip Skokan) #59544
  * (SEMVER-MINOR) support SLH-DSA KeyObject, sign, and verify (Filip Skokan) #59537
inspector:
  * add http2 tracking support (Darshan Sen) #59611
worker:
  * (SEMVER-MINOR) add cpu profile APIs for worker (theanarkh) #59428

PR-URL: #59816

@nodejs-github-bot @targos

Notable changes:

crypto:
  * (SEMVER-MINOR) support Ed448 and ML-DSA context parameter in node:crypto (Filip Skokan) #59570
  * (SEMVER-MINOR) support Ed448 and ML-DSA context parameter in Web Cryptography (Filip Skokan) #59570
  * (SEMVER-MINOR) add KMAC Web Cryptography algorithms (Filip Skokan) #59647
  * (SEMVER-MINOR) add Argon2 Web Cryptography algorithms (Filip Skokan) #59544
  * (SEMVER-MINOR) support SLH-DSA KeyObject, sign, and verify (Filip Skokan) #59537
inspector:
  * add http2 tracking support (Darshan Sen) #59611
worker:
  * (SEMVER-MINOR) add cpu profile APIs for worker (theanarkh) #59428

PR-URL: #59816

RafaelGSS

richardlau

@targos targos deleted the v24.8.0-proposal branch

September 10, 2025 19:35

targos added a commit that referenced this pull request

Sep 10, 2025

targos pushed a commit that referenced this pull request

Sep 10, 2025
Notable changes:

crypto:
  * (SEMVER-MINOR) support Ed448 and ML-DSA context parameter in node:crypto (Filip Skokan) #59570
  * (SEMVER-MINOR) support Ed448 and ML-DSA context parameter in Web Cryptography (Filip Skokan) #59570
  * (SEMVER-MINOR) add KMAC Web Cryptography algorithms (Filip Skokan) #59647
  * (SEMVER-MINOR) add Argon2 Web Cryptography algorithms (Filip Skokan) #59544
  * (SEMVER-MINOR) support SLH-DSA KeyObject, sign, and verify (Filip Skokan) #59537
inspector:
  * add http2 tracking support (Darshan Sen) #59611
worker:
  * (SEMVER-MINOR) add cpu profile APIs for worker (theanarkh) #59428

PR-URL: #59816

targos added a commit to targos/nodejs.org that referenced this pull request

Sep 10, 2025

jhaynardresos09-beep