Home Original page

test: fix test-dns.js flakiness by Trott · Pull Request #5996 · nodejs/node

@Trott 

Use empty string instead of `www.google.com` for tests where we are just
doing parameter evaluation. This will avoid DNS lookups which appear to
be causing flakiness on Raspberry Pi devices in CI.

Fixes: nodejs#5554

@Trott added dns

Issues and PRs related to the dns subsystem.

test

Issues and PRs related to the tests.

lts-watch-v4.x labels

Apr 1, 2016

@Trott Trott mentioned this pull request

Apr 1, 2016

Trott added a commit to Trott/io.js that referenced this pull request

Apr 4, 2016 
Use empty string instead of `www.google.com` for tests where we are just
doing parameter evaluation. This will avoid DNS lookups which appear to
be causing flakiness on Raspberry Pi devices in CI.

PR-URL: nodejs#5996
Fixes: nodejs#5554
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Apr 5, 2016 
Use empty string instead of `www.google.com` for tests where we are just
doing parameter evaluation. This will avoid DNS lookups which appear to
be causing flakiness on Raspberry Pi devices in CI.

PR-URL: #5996
Fixes: #5554
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

This was referenced

Apr 5, 2016

MylesBorins pushed a commit that referenced this pull request

Apr 11, 2016 
Use empty string instead of `www.google.com` for tests where we are just
doing parameter evaluation. This will avoid DNS lookups which appear to
be causing flakiness on Raspberry Pi devices in CI.

PR-URL: #5996
Fixes: #5554
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>