Home Original page

test: explicitly set global in test-repl by Trott · Pull Request #6026 · nodejs/node

@Trott 

The test intentionally assigns a global. Use `global` namespace to make
it clear that it is intentional and not an accidental leak.

@Trott added repl

Issues and PRs related to the REPL subsystem.

test

Issues and PRs related to the tests.

lts-watch-v4.x labels

Apr 3, 2016

jasnell pushed a commit that referenced this pull request

Apr 4, 2016 
The test intentionally assigns a global. Use `global` namespace to make
it clear that it is intentional and not an accidental leak.

PR-URL: #6026
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Apr 5, 2016 
The test intentionally assigns a global. Use `global` namespace to make
it clear that it is intentional and not an accidental leak.

PR-URL: #6026
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

This was referenced

Apr 5, 2016

MylesBorins pushed a commit that referenced this pull request

Apr 11, 2016 
The test intentionally assigns a global. Use `global` namespace to make
it clear that it is intentional and not an accidental leak.

PR-URL: #6026
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>