Home Original page

test: fix flakiness of stringbytes-external by ofrobots · Pull Request #6039 · nodejs/node

@jasnell added test

Issues and PRs related to the tests.

lib / src

Issues and PRs related to general changes in the lib or src directory.

lts-watch-v4.x labels

Apr 4, 2016

@ofrobots 

The tests used to rely on precise timing of when a JavaScript object
would be garbage collected to ensure that there is enough memory
available on the system. Switch the test to use a malloc/free pair
instead.

Ref: nodejs#5945

ofrobots added a commit to ofrobots/node that referenced this pull request

Apr 5, 2016 
The tests used to rely on precise timing of when a JavaScript object
would be garbage collected to ensure that there is enough memory
available on the system. Switch the test to use a malloc/free pair
instead.

Ref: nodejs#5945
PR-URL: nodejs#6039
Reviewed-By: jasnell - James M Snell <jasnell@gmail.com>
Reviewed-By: evanlucas - Evan Lucas <evanlucas@me.com>
Reviewed-By: Trott - Rich Trott <rtrott@gmail.com>

ofrobots added a commit to ofrobots/node that referenced this pull request

Apr 6, 2016 
Avoid depending on precise timing of when an object will be collected
by GC. This test was missed by nodejs#6039 as it happened to be in a
different directory than the rest.

Ref: nodejs#6039
PR-URL: nodejs#6073
Reviewed-By: Trott - Rich Trott <rtrott@gmail.com>

ofrobots added a commit to ofrobots/node that referenced this pull request

May 12, 2016 
The tests used to rely on precise timing of when a JavaScript object
would be garbage collected to ensure that there is enough memory
available on the system. Switch the test to use a malloc/free pair
instead.

Ref: nodejs#5945
Ref: nodejs#6039
Ref: nodejs#6073

MylesBorins pushed a commit that referenced this pull request

May 13, 2016 
The tests used to rely on precise timing of when a JavaScript object
would be garbage collected to ensure that there is enough memory
available on the system. Switch the test to use a malloc/free pair
instead.

Ref: #5945
Ref: #6039
Ref: #6073

PR-URL: #6705
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins pushed a commit that referenced this pull request

May 18, 2016 
The tests used to rely on precise timing of when a JavaScript object
would be garbage collected to ensure that there is enough memory
available on the system. Switch the test to use a malloc/free pair
instead.

Ref: #5945
Ref: #6039
Ref: #6073

PR-URL: #6705
Reviewed-By: James M Snell <jasnell@gmail.com>