Home Original page

repl: refactor `LineParser` implementation by blakeembrey · Pull Request #6171 · nodejs/node

@mscdex added the repl

Issues and PRs related to the REPL subsystem.

label

Apr 12, 2016

@Fishrock123 Fishrock123 added the semver-major

PRs that contain breaking changes and should be released in the next major version.

label

Jun 17, 2016

@blakeembrey 

Move the core logic from `LineParser` should fail handling into the
recoverable error check for the REPL default eval.

jasnell pushed a commit that referenced this pull request

Mar 14, 2017 
Move the core logic from `LineParser` should fail handling into the
recoverable error check for the REPL default eval.

PR-URL: #6171
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

hybrist

hybrist pushed a commit to hybrist/node that referenced this pull request

Mar 15, 2017

jasnell pushed a commit that referenced this pull request

Mar 17, 2017 
This fixes a regression introduced in #6171

PR-URL: #11871
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

jungx098 pushed a commit to jungx098/node that referenced this pull request

Mar 21, 2017 
Move the core logic from `LineParser` should fail handling into the
recoverable error check for the REPL default eval.

PR-URL: nodejs#6171
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

jungx098 pushed a commit to jungx098/node that referenced this pull request

Mar 21, 2017 
This fixes a regression introduced in nodejs#6171

PR-URL: nodejs#11871
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

vsemozhetbyt added a commit that referenced this pull request

Apr 28, 2017 
Delete unused method call.

PR-URL: #12685
Refs: #6171
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

@lance lance mentioned this pull request

Oct 4, 2017

3 tasks

MylesBorins pushed a commit that referenced this pull request

Nov 14, 2017 
Move the core logic from `LineParser` should fail handling into the
recoverable error check for the REPL default eval.

Fixes: #15704
Backport-PR-URL: #15773
PR-URL: #6171
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>