deps: backport Intl.NumberFormat fix by targos · Pull Request #6275 · nodejs/node

added 2 commits

April 19, 2016 10:00
Original commit message:

    Make NumberFormat use the ICU currency data, fix bug in NumberFormat

    NumberFormat previously just used a min of 0 digits after the decimal and a max of 3. This CL changes it so that we use the ICU currency data, and set the min and max to the number of numbers after the decimal point for each currency.

    This CL also fixes a small bug where if the minimum fraction digits is above 3 but the maximum fraction digits isn't set, then it returns with only three numbers after the decimal point.

    BUG=435465,473104,304722
    LOG=Y

    Review URL: https://codereview.chromium.org/1231613006

    Cr-Commit-Position: refs/heads/master@{nodejs#29734}
Original commit message:

    Fix user options for fractional digits in Intl.NumberFormatter

    The patch in https://crrev.com/ddb5c2d999c5ee6e31c4a9599bb3ddb293cc3f49
    moved all fractional digit settings to default values due to a coding
    error. These were not even correct default values, and users observed
    errors where percentages were written as "23.0%" instead of "23%".

    This patch fixes the setting propagation when appropriate and it changes
    the default max fractional digits of a percentage to 0, per spec.

    BUG=chromium:544122
    R=mnita,jochen
    CC=hichris123,adamk
    LOG=Y

    Review URL: https://codereview.chromium.org/1420883002

    Cr-Commit-Position: refs/heads/master@{nodejs#31468}

@targos targos added the i18n-api

Issues and PRs related to the i18n implementation.

label

Apr 19, 2016

jasnell pushed a commit that referenced this pull request

Apr 20, 2016
Original commit message:

    Make NumberFormat use the ICU currency data, fix bug in NumberFormat

    NumberFormat previously just used a min of 0 digits after the decimal and a max of 3. This CL changes it so that we use the ICU currency data, and set the min and max to the number of numbers after the decimal point for each currency.

    This CL also fixes a small bug where if the minimum fraction digits is above 3 but the maximum fraction digits isn't set, then it returns with only three numbers after the decimal point.

    BUG=435465,473104,304722
    LOG=Y

    Review URL: https://codereview.chromium.org/1231613006

    Cr-Commit-Position: refs/heads/master@{#29734}

PR-URL: #6275
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>

jasnell pushed a commit that referenced this pull request

Apr 20, 2016
Original commit message:

    Fix user options for fractional digits in Intl.NumberFormatter

    The patch in https://crrev.com/ddb5c2d999c5ee6e31c4a9599bb3ddb293cc3f49
    moved all fractional digit settings to default values due to a coding
    error. These were not even correct default values, and users observed
    errors where percentages were written as "23.0%" instead of "23%".

    This patch fixes the setting propagation when appropriate and it changes
    the default max fractional digits of a percentage to 0, per spec.

    BUG=chromium:544122
    R=mnita,jochen
    CC=hichris123,adamk
    LOG=Y

    Review URL: https://codereview.chromium.org/1420883002

    Cr-Commit-Position: refs/heads/master@{#31468}

PR-URL: #6275
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>