build: use shorthand lint target from test by jbergstroem · Pull Request #6406 · nodejs/node
Instead of invoking jslint/cpplint from the test target, call on the generic lint instead since it checks if eslint exists. Since our tarballs lacks eslint we now get a more graceful exit from `make test` instead of a traceback from jslint. PR-URL: nodejs#6406 Fixes: nodejs#6408 Reviewed-By: Ryan Graham <r.m.graham@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Fishrock123 pushed a commit that referenced this pull request
May 4, 2016
Instead of invoking jslint/cpplint from the test target, call on the generic lint instead since it checks if eslint exists. Since our tarballs lacks eslint we now get a more graceful exit from `make test` instead of a traceback from jslint. PR-URL: #6406 Fixes: #6408 Reviewed-By: Ryan Graham <r.m.graham@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced
May 4, 2016joelostrowski pushed a commit to joelostrowski/node that referenced this pull request
May 4, 2016
Instead of invoking jslint/cpplint from the test target, call on the generic lint instead since it checks if eslint exists. Since our tarballs lacks eslint we now get a more graceful exit from `make test` instead of a traceback from jslint. PR-URL: nodejs#6406 Fixes: nodejs#6408 Reviewed-By: Ryan Graham <r.m.graham@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters