unix,stream: fix getting the correct fd for a handle by saghul · Pull Request #6838

unix,stream: fix getting the correct fd for a handle by saghul · Pull Request #6838 · nodejs/node

added the c++

Issues and PRs that require attention from people who are familiar with C++.

label

May 18, 2016

mscdex added the stream

Issues and PRs related to the stream subsystem.

label

May 18, 2016

kzc mentioned this pull request

May 18, 2016

4 tasks

On OSX it's possible that the fd is replaced, so use the proper libuv
API to get the correct fd.

PR-URL: nodejs#6753
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

saghul added a commit to saghul/node that referenced this pull request

May 23, 2016

Refs: nodejs#6838
PR-URL: nodejs#6908
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

kzc mentioned this pull request

May 25, 2016

8 tasks

Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request

May 30, 2016

Refs: nodejs#6838
PR-URL: nodejs#6908
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

rvagg pushed a commit that referenced this pull request

Jun 2, 2016

Refs: #6838
PR-URL: #6908
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

saghul added a commit to saghul/node that referenced this pull request

Jul 11, 2016

Refs: nodejs#6838
PR-URL: nodejs#6908
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>