Home Original page

zlib: refactor constants for consistency by jasnell · Pull Request #7203 · nodejs/node

@jasnell added zlib

Issues and PRs related to the zlib subsystem.

semver-major

PRs that contain breaking changes and should be released in the next major version.

labels

Jun 7, 2016

@nodejs-github-bot nodejs-github-bot added the c++

Issues and PRs that require attention from people who are familiar with C++.

label

Jun 7, 2016

@jasnell 

zlib constants were previously being added to binding in node_zlib.cc.
This moves the zlib constants to node_constants.cc for consistency with
the recent constants refactoring:
  nodejs#6534

Adds require('zlib').constants to expose the constants
Docs-only deprecates the constants hung directly off require('zlib')
Removes a couple constants from the docs that apparently no longer
exist in the code

@jasnell

jasnell added a commit that referenced this pull request

Jun 12, 2016 
zlib constants were previously being added to binding in node_zlib.cc.
This moves the zlib constants to node_constants.cc for consistency with
the recent constants refactoring:
  #6534

Adds require('zlib').constants to expose the constants
Docs-only deprecates the constants hung directly off require('zlib')
Removes a couple constants from the docs that apparently no longer
exist in the code

PR-URL: #7203
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

fhinkel added a commit to fhinkel/node that referenced this pull request

Jul 9, 2016 
Some constants in the zlib docs are not in the actual code:

zlib.Z_BINARY
zlib.Z_TEXT
zlib.Z_ASCII
zlib.Z_UNKNOWN

Also handled in nodejs#7203, but marked as
semver-major, so will not land in v6.x.

Fixes: nodejs#7204

Fishrock123 pushed a commit that referenced this pull request

Jul 15, 2016 
Some constants in the zlib docs are not in the actual code:

zlib.Z_BINARY
zlib.Z_TEXT
zlib.Z_ASCII
zlib.Z_UNKNOWN

Also handled in #7203, but marked as
semver-major, so will not land in v6.x.

Fixes: #7204
PR-URL: #7520
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

MylesBorins pushed a commit that referenced this pull request

Sep 9, 2016 
Some constants in the zlib docs are not in the actual code:

zlib.Z_BINARY
zlib.Z_TEXT
zlib.Z_ASCII
zlib.Z_UNKNOWN

Also handled in #7203, but marked as
semver-major, so will not land in v6.x.

Fixes: #7204
PR-URL: #7520
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

MylesBorins pushed a commit that referenced this pull request

Sep 28, 2016 
Some constants in the zlib docs are not in the actual code:

zlib.Z_BINARY
zlib.Z_TEXT
zlib.Z_ASCII
zlib.Z_UNKNOWN

Also handled in #7203, but marked as
semver-major, so will not land in v6.x.

Fixes: #7204
PR-URL: #7520
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

rvagg pushed a commit that referenced this pull request

Oct 18, 2016 
Some constants in the zlib docs are not in the actual code:

zlib.Z_BINARY
zlib.Z_TEXT
zlib.Z_ASCII
zlib.Z_UNKNOWN

Also handled in #7203, but marked as
semver-major, so will not land in v6.x.

Fixes: #7204
PR-URL: #7520
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

MylesBorins pushed a commit that referenced this pull request

Oct 26, 2016 
Some constants in the zlib docs are not in the actual code:

zlib.Z_BINARY
zlib.Z_TEXT
zlib.Z_ASCII
zlib.Z_UNKNOWN

Also handled in #7203, but marked as
semver-major, so will not land in v6.x.

Fixes: #7204
PR-URL: #7520
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>