Home Original page

url: return valid file: urls fom url.format() by Trott · Pull Request #7234 · nodejs/node

@Trott added url

Issues and PRs related to the legacy built-in url module.

semver-major

PRs that contain breaking changes and should be released in the next major version.

labels

Jun 8, 2016

@Trott Trott mentioned this pull request

Jun 9, 2016

3 tasks 

`file:` URLs that do not start with `file://` are invalid. Browsers
convert `file:/etc/passwd` to `file:///etc/passwd`. This is also what
the docs indicate we are doing, but we're not.

Fixes: nodejs#3361

@Trott

@Trott

@rvagg rvagg mentioned this pull request

Jun 15, 2016

Trott added a commit to Trott/io.js that referenced this pull request

Jun 16, 2016 
`file:` URLs that do not start with `file://` are invalid. Browsers
convert `file:/etc/passwd` to `file:///etc/passwd`. This is also what
the docs indicate we are doing, but we're not.

PR-URL: nodejs#7234
Fixes: nodejs#3361
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Brian White <mscdex@mscdex.net>

@iarna iarna mentioned this pull request

Nov 8, 2016

@Trott Trott deleted the fileslashslash branch

January 13, 2022 22:43