inspector: Put connect and disconnect events into message queue by eugeneo · Pull Request #7271

inspector: Put connect and disconnect events into message queue by eugeneo · Pull Request #7271 · nodejs/node

added the c++

Issues and PRs that require attention from people who are familiar with C++.

label

Jun 11, 2016

mscdex added inspector

Issues and PRs related to the V8 inspector protocol

c++

Issues and PRs that require attention from people who are familiar with C++.

and removed c++

Issues and PRs that require attention from people who are familiar with C++.

labels

Jun 11, 2016

Current implementation tracks connected/disconnected status separately
which potentially introduces race condition.
This change introduces notion of session IDs and also posts
connect/disconnect events into the same queue as the messages. This way
Node knows what session given response belongs to and can discard
messages if the frontend for that session had disconnected.

This also fixes an issue when frontend was unable to attach to V8
instance that was running infinite loop.

ofrobots pushed a commit that referenced this pull request

Jul 15, 2016

Current implementation tracks connected/disconnected status separately
which potentially introduces race condition.
This change introduces notion of session IDs and also posts
connect/disconnect events into the same queue as the messages. This way
Node knows what session given response belongs to and can discard
messages if the frontend for that session had disconnected.

This also fixes an issue when frontend was unable to attach to V8
instance that was running infinite loop.

PR-URL: #7271
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>

evanlucas pushed a commit that referenced this pull request

Jul 18, 2016

Current implementation tracks connected/disconnected status separately
which potentially introduces race condition.
This change introduces notion of session IDs and also posts
connect/disconnect events into the same queue as the messages. This way
Node knows what session given response belongs to and can discard
messages if the frontend for that session had disconnected.

This also fixes an issue when frontend was unable to attach to V8
instance that was running infinite loop.

PR-URL: #7271
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>

evanlucas pushed a commit that referenced this pull request

Jul 20, 2016

Current implementation tracks connected/disconnected status separately
which potentially introduces race condition.
This change introduces notion of session IDs and also posts
connect/disconnect events into the same queue as the messages. This way
Node knows what session given response belongs to and can discard
messages if the frontend for that session had disconnected.

This also fixes an issue when frontend was unable to attach to V8
instance that was running infinite loop.

PR-URL: #7271
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>