Home Original page

[v4.x backport] test: run v8 tests from node tree by MylesBorins · Pull Request #7451 · nodejs/node

@MylesBorins added v8 engine

Issues and PRs related to the V8 dependency.

tools

Issues and PRs related to the tools directory.

v4.x semver-minor

PRs that contain new features and should be released in the next minor version.

labels

Jun 28, 2016

@mscdex mscdex added the test

Issues and PRs related to the tests.

label

Jun 28, 2016

@MylesBorins MylesBorins changed the title test: run v8 tests from node tree test: run v8 tests from node tree [v4.x backport]

Jun 28, 2016

@MylesBorins MylesBorins changed the title test: run v8 tests from node tree [v4.x backport] [WIP] test: run v8 tests from node tree [v4.x backport]

Jun 29, 2016

@MylesBorins MylesBorins added the wip

Issues and PRs that are still a work in progress.

label

Jun 29, 2016

@MylesBorins MylesBorins changed the title [WIP] test: run v8 tests from node tree [v4.x backport] [WIP][v4.x backport] test: run v8 tests from node tree

Jun 29, 2016

@exinfinitum 

Ported by exinfinitum from a PR by jasnell:
see nodejs/node-v0.x-archive#14185

Allows the running of v8 tests on node's packaged v8 source code.

Note that the limited win32 support added by jasnell has NOT been ported,
and so these tests are currently UNIX ONLY.

Note that gclient depot tools
(see https://commondatastorage.googleapis.com/
chrome-infra-docs/flat/depot_tools/docs/html/
depot_tools_tutorial.html#_setting_up) and subversion are required
to run tests.

To perform tests, run the following commands:

make v8 DESTCPU=(ARCH)
make test-v8 DESTCPU=(ARCH)

where (ARCH) is your CPU architecture, e.g. x64, ia32.
DESTCPU MUST be specified for this to work properly.

Can also do tests on debug build by using "make test-v8 DESTCPU=(ARCH)
BUILDTYPE=Debug", or perform intl or benchmark tests via make
test-v8-intl or test-v8-benchmarks respectively.

Note that by default, quickcheck and TAP output are disabled, and i18n
is enabled. To activate these options, use options"QUICKCHECK=True" and
"ENABLE_V8_TAP=True" respectively.

Use "DISABLE_V8_I18N" to disable i18n.

Use V8_BUILD_OPTIONS to allow custom user-defined flags to be
appended onto "make v8".

Any tests performed after changes to the packaged v8 file will require
recompiling of v8, which can be done using "make v8 DESTCPU=(ARCH)".

Finally, two additional files necessary for one of the v8 tests have
been added to the v8 folder.

PR-URL: nodejs#4704
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com>

@MylesBorins MylesBorins removed the wip

Issues and PRs that are still a work in progress.

label

Jun 29, 2016

@MylesBorins MylesBorins changed the title [WIP][v4.x backport] test: run v8 tests from node tree [v4.x backport] test: run v8 tests from node tree

Jun 29, 2016 
Original commit message:

    [test] Set default locale in test runner

    BUG=v8:4437,v8:2899,chromium:604310
    LOG=n

    Review URL: https://codereview.chromium.org/1402373002

    Cr-Commit-Position: refs/heads/master@{nodejs#35614}

PR-URL: nodejs#7451
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Currently we do not specific an absolute path for the tap output of the
V8 test suite. This is proving to be unreliable across release lines.

By prepending `$(PWD)` to each path we can guarantee it will always be
in the root folder.

PR-URL: nodejs#7460
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>

MylesBorins added a commit that referenced this pull request

Jul 12, 2016

MylesBorins pushed a commit that referenced this pull request

Jul 12, 2016 
Notable Changes:

This list is not yet complete. Please comment in the thread with
commits you think should be included. Descriptions will also be
updated in a later release candidate.

Semver Minor:

* buffer:
 * backport new buffer constructor APIs to v4.x
   (Сковорода Никита Андреевич)
   #7562
 * ignore negative allocation lengths (Anna Henningsen)
   #7562
 * backport --zero-fill-buffers cli option (James M Snell)
   #5745
* build:
  * add Intel Vtune profiling support (Chunyang Dai)
    #5527
* repl:
  * copying tabs shouldn't trigger completion (Eugene Obrezkov)
    #5958
* src:
  * add node::FreeEnvironment public API (Cheng Zhao)
    #3098
* test:
  * run v8 tests from node tree (Bryon Leung)
    #4704
* V8:
  * backport 9c927d0f01 from V8 upstream (Myles Borins)
    #7451
  * cherry-pick 68e89fb from v8's upstream (Fedor Indutny)
    #3779

Semver Patch:

* **libuv**:
  * upgrade libuv to 1.9.1 (Saúl Ibarra Corretgé)
    #6796
  * upgrade libuv to 1.9.0 (Saúl Ibarra Corretgé)
    #5994

richardlau added a commit to ibmruntimes/node that referenced this pull request

Jul 14, 2016 
Original commit message:

deps: backport 9c927d0f01 from V8 upstream

Original commit message:

    [test] Set default locale in test runner

    BUG=v8:4437,v8:2899,chromium:604310
    LOG=n

    Review URL: https://codereview.chromium.org/1402373002

    Cr-Commit-Position: refs/heads/master@{#35614}

PR-URL: nodejs/node#7451
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>