src: fix build on CentOS by Trott · Pull Request #7873

src: fix build on CentOS by Trott · Pull Request #7873 · nodejs/node

added the wip

Issues and PRs that are still a work in progress.

label

Jul 25, 2016

nodejs-github-bot added the c++

Issues and PRs that require attention from people who are familiar with C++.

label

Jul 25, 2016

85af1a6 was added (squashed into another commit) without running
through CI. Unfortunately, it breaks some of the CI builds, notably on
three of the CentOS setups.

Undoing that one small change to get builds green again.

Refs: nodejs#7547 (comment)
PR-URL: nodejs#7873

Trott removed the wip

Issues and PRs that are still a work in progress.

label

Jul 25, 2016

Trott changed the title ~~WIP: 85af1a609fc05~~ src: fix build on CentOS

Jul 25, 2016

Trott mentioned this pull request

Jul 25, 2016

2 tasks

This was referenced

Jul 25, 2016

Trott added a commit to Trott/io.js that referenced this pull request

Jul 25, 2016

85af1a6 was added (squashed into another commit) without running
through CI. Unfortunately, it breaks some of the CI builds, notably on
three of the CentOS setups.

Undoing that one small change to get builds green again.

Refs: nodejs#7547 (comment)
PR-URL: nodejs#7873
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

cjihrig pushed a commit that referenced this pull request

Aug 10, 2016

85af1a6 was added (squashed into another commit) without running
through CI. Unfortunately, it breaks some of the CI builds, notably on
three of the CentOS setups.

Undoing that one small change to get builds green again.

Refs: #7547 (comment)
PR-URL: #7873
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

Trott deleted the revert-revert-revert branch

January 13, 2022 22:43