Do not copy value onto vm sandbox in strict mode by fhinkel · Pull Request #7908

Do not copy value onto vm sandbox in strict mode by fhinkel · Pull Request #7908 · nodejs/node

added the c++

Issues and PRs that require attention from people who are familiar with C++.

label

Jul 28, 2016

addaleax added the vm

Issues and PRs related to the vm subsystem.

label

Jul 28, 2016

In vm, the setter interceptor should not copy a value onto the
sandbox, if setting it on the global object will fail. It will fail if
we are in strict mode and set a value without declaring it.

Fixes nodejs#5344

jasnell pushed a commit that referenced this pull request

Aug 4, 2016

In vm, the setter interceptor should not copy a value onto the
sandbox, if setting it on the global object will fail. It will fail if
we are in strict mode and set a value without declaring it.

Fixes: #5344
PR-URL: #7908
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

cjihrig pushed a commit that referenced this pull request

Aug 10, 2016

In vm, the setter interceptor should not copy a value onto the
sandbox, if setting it on the global object will fail. It will fail if
we are in strict mode and set a value without declaring it.

Fixes: #5344
PR-URL: #7908
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>