Home Original page

test: fixes for more strict linting by Trott · Pull Request #7920 · nodejs/node

@Trott added wip

Issues and PRs that are still a work in progress.

test

Issues and PRs related to the tests.

tools

Issues and PRs related to the tools directory.

labels

Jul 30, 2016

@Trott Trott removed the wip

Issues and PRs that are still a work in progress.

label

Aug 1, 2016

@Trott Trott changed the title [WIP] tools: fixes for more strict linting [WIP] test: fixes for more strict linting

Aug 1, 2016

@Trott 

A new version of ESLint flags chained properties on multiple lines that
were not flagged by the previous version of ESLint. In preparation for
turning that feature on, adjust alignment to that expected by the
linter.

This change happened to be predominantly around assertions using
`assert()` and `assert.equal()`. These were changed to
`assert.strictEqual()` where possible.

@Trott Trott changed the title [WIP] test: fixes for more strict linting test: fixes for more strict linting

Aug 1, 2016

Trott added a commit to Trott/io.js that referenced this pull request

Aug 2, 2016 
A new version of ESLint flags chained properties on multiple lines that
were not flagged by the previous version of ESLint. In preparation for
turning that feature on, adjust alignment to that expected by the
linter.

This change happened to be predominantly around assertions using
`assert()` and `assert.equal()`. These were changed to
`assert.strictEqual()` where possible.

PR-URL: nodejs#7920
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

@Trott Trott mentioned this pull request

Aug 6, 2016

2 tasks

Trott added a commit to Trott/io.js that referenced this pull request

Aug 9, 2016

Trott added a commit to Trott/io.js that referenced this pull request

Aug 10, 2016 
Refs: nodejs#7920
PR-URL: nodejs#7999
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>

cjihrig pushed a commit that referenced this pull request

Aug 10, 2016 
A new version of ESLint flags chained properties on multiple lines that
were not flagged by the previous version of ESLint. In preparation for
turning that feature on, adjust alignment to that expected by the
linter.

This change happened to be predominantly around assertions using
`assert()` and `assert.equal()`. These were changed to
`assert.strictEqual()` where possible.

PR-URL: #7920
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

Conflicts:
	test/parallel/test-readline-interface.js

cjihrig pushed a commit that referenced this pull request

Aug 10, 2016 
Refs: #7920
PR-URL: #7999
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>

@Trott Trott deleted the eslint-update branch

October 10, 2021 01:39