Home Original page

repl: disable Ctrl+C support on win32 for now by addaleax · Pull Request #7977 · nodejs/node

@addaleax 

Disable Windows support for interrupting REPL commands using
Ctrl+C by default, because the switches from console raw mode
and back have been interfering with printing the results of
evaluated expressions.

This is a temporary measure, since the underlying problem is
very likely not related to this specific feature.

Ref: nodejs#7837

@addaleax added repl

Issues and PRs related to the REPL subsystem.

windows

Issues and PRs related to the Windows platform.

labels

Aug 4, 2016

@addaleax

jasnell pushed a commit that referenced this pull request

Aug 8, 2016 
Disable Windows support for interrupting REPL commands using
Ctrl+C by default, because the switches from console raw mode
and back have been interfering with printing the results of
evaluated expressions.

This is a temporary measure, since the underlying problem is
very likely not related to this specific feature.

Ref: #7837

PR-URL: #7977
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: João Reis <reis@janeasystems.com>

@addaleax addaleax deleted the disable-ctrlc-windows branch

August 8, 2016 16:45

cjihrig pushed a commit that referenced this pull request

Aug 10, 2016 
Disable Windows support for interrupting REPL commands using
Ctrl+C by default, because the switches from console raw mode
and back have been interfering with printing the results of
evaluated expressions.

This is a temporary measure, since the underlying problem is
very likely not related to this specific feature.

Ref: #7837

PR-URL: #7977
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: João Reis <reis@janeasystems.com>