Home Original page

test: fix flaky test-vm-sigint-existing-handler by addaleax · Pull Request #7982 · nodejs/node

@addaleax 

Set the `SIGUSR2` handler before spawning the child process to make sure
the signal is always handled.

Ref: nodejs#7854
Fixes: nodejs#7981

@nodejs-github-bot added the test

Issues and PRs related to the tests.

label

Aug 4, 2016

@addaleax

@mscdex mscdex added the vm

Issues and PRs related to the vm subsystem.

label

Aug 4, 2016

@addaleax

addaleax added a commit that referenced this pull request

Aug 8, 2016 
Set the `SIGUSR2` handler before spawning the child process to make sure
the signal is always handled.

Ref: #7854
Fixes: #7981
PR-URL: #7982
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

@addaleax addaleax deleted the fix-test-vm-sigint-existing-handler-flakiness branch

August 8, 2016 13:00

cjihrig pushed a commit that referenced this pull request

Aug 10, 2016 
Set the `SIGUSR2` handler before spawning the child process to make sure
the signal is always handled.

Ref: #7854
Fixes: #7981
PR-URL: #7982
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>