test: improve test-child-process-fork-dgram by mhdawson · Pull Request #8697 · nodejs/node
This was referenced
Sep 21, 2016labels
Sep 21, 2016
Previous implementation was subject to timing out as there was no guarantee that the parent or child would ever receive a message. Modified test so that once parent or child receives a message it closes its connection to the socket so we can guarantee the next messsage will be recieved by the other node. The test also left lingering processes when it timed out so pulled the timeout into the test itself so that it could properly cleanup in case of failure.
Trott added a commit to Trott/io.js that referenced this pull request
Oct 14, 2016
`test-child-process-fork-dgram` is unreliable on some platforms, especially FreeBSD and AIX within the project's continuous integration testing. It has also been observed to be flaky on macos. * Confirm child has received the server before sending packets * Close the server instance on the parent or child after receiving a Refs: nodejs#8697 Fixes: nodejs#8949 Fixes: nodejs#8271
Trott
mentioned this pull request
2 tasks
Trott added a commit to Trott/io.js that referenced this pull request
Oct 18, 2016
`test-child-process-fork-dgram` is unreliable on some platforms, especially FreeBSD and AIX within the project's continuous integration testing. It has also been observed to be flaky on macos. * Confirm child has received the server before sending packets * Close the server instance on the parent or child after receiving a Refs: nodejs#8697 Fixes: nodejs#8949 Fixes: nodejs#8271 PR-URL: nodejs#9098 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
jasnell pushed a commit that referenced this pull request
Oct 18, 2016
`test-child-process-fork-dgram` is unreliable on some platforms, especially FreeBSD and AIX within the project's continuous integration testing. It has also been observed to be flaky on macos. * Confirm child has received the server before sending packets * Close the server instance on the parent or child after receiving a Refs: #8697 Fixes: #8949 Fixes: #8271 PR-URL: #9098 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Trott added a commit to Trott/io.js that referenced this pull request
Nov 12, 2016
`test-child-process-fork-dgram` is unreliable on some platforms, especially FreeBSD and AIX within the project's continuous integration testing. It has also been observed to be flaky on macos. * Confirm child has received the server before sending packets * Close the server instance on the parent or child after receiving a Refs: nodejs#8697 Fixes: nodejs#8949 Fixes: nodejs#8271 PR-URL: nodejs#9098 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Trott
mentioned this pull request
Trott added a commit to Trott/io.js that referenced this pull request
Nov 12, 2016
`test-child-process-fork-dgram` is unreliable on some platforms, especially FreeBSD and AIX within the project's continuous integration testing. It has also been observed to be flaky on macos. * Confirm child has received the server before sending packets * Close the server instance on the parent or child after receiving a Refs: nodejs#8697 Fixes: nodejs#8949 Fixes: nodejs#8271 PR-URL: nodejs#9098 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Trott
mentioned this pull request
MylesBorins pushed a commit that referenced this pull request
Nov 14, 2016
`test-child-process-fork-dgram` is unreliable on some platforms, especially FreeBSD and AIX within the project's continuous integration testing. It has also been observed to be flaky on macos. * Confirm child has received the server before sending packets * Close the server instance on the parent or child after receiving a Refs: #8697 Fixes: #8949 Fixes: #8271 PR-URL: #9098 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
MylesBorins pushed a commit that referenced this pull request
Nov 15, 2016
`test-child-process-fork-dgram` is unreliable on some platforms, especially FreeBSD and AIX within the project's continuous integration testing. It has also been observed to be flaky on macos. * Confirm child has received the server before sending packets * Close the server instance on the parent or child after receiving a Refs: #8697 Fixes: #8949 Fixes: #8271 PR-URL: #9098 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters